Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update JSEP reference in RTCIceTransportState definition #991

Merged
merged 3 commits into from
Jan 12, 2017
Merged

Update JSEP reference in RTCIceTransportState definition #991

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f71d80a
update JSEP reference
burnburn Jan 11, 2017
1db75ab
removed JSEP ref
burnburn Jan 12, 2017
5695063
wording fix
burnburn Jan 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions webrtc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7051,10 +7051,13 @@ <h3>RTCIceTransportState Enum</h3>
</div>
<p>The <code>failed</code> and <code>completed</code> states require an
indication that there are no additional remote candidates. This can be
indicated either by <a data-link-for=
indicated by calling <code><a>addIceCandidate</a></code> with
a candidate value whose <code>candidate</code> property is set
to an empty string, by <a data-link-for=
"RTCPeerConnection">canTrickleIceCandidates</a> being set to
<code>false</code>, or the processing of an end-of-candidates indication
as described in [[!JSEP]].</p>
<code>false</code>, or the processing of an end-of-candidates
indication as described
in <span data-jsep="addicecandidate">[[!JSEP]]</span>.</p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I read JSEP at the moment, the end-of-candidates indication is the same as calling with a candidate value whose candidate property is the empty string, so this is saying the same thing twice.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the truth is that I still don't believe JSEP anywhere actually describes processing of an end-of-candidates indication but do believe that I'm never going to get a proper answer on that, so I almost deleted the reference to JSEP altogether. I am happy to delete everything from ', or the processing . . .' onwards.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting everythign after the comma would work for me.

<p>Some example transitions might be:</p>
<ul>
<li>(<code><a>RTCIceTransport</a></code> first created, as a result of
Expand Down