Describe when an RTCSctpTransport is created/set to null. #996
Conversation
Fixes w3c#979. An SctpTransport represents a unique SCTP association. It's created from applying a local description, and set to null when applying an answer with a rejected data m= section.
taylor-b
force-pushed
the
issue_979_sctptransport_lifetime
branch
from
1e296a1
to
53a0ffe
Compare
| and it creates a new SCTP association, as defined in | ||
| [[!SCTP-SDP]], set the value of <var>connection</var>'s | ||
| [[<code><a>sctpTransport</a></code>]] internal slot | ||
| to a newly created <code><a>RTCSctpTransport</a></code>.</p> |
There was a problem hiding this comment.
I don't believe that a new SCTP association can be created until setRemoteDescription is called, because until then the remote port isn't known. So you might say, "creates a new RTCSctpTransport object.".
There was a problem hiding this comment.
Would "initiates a new SCTP association" be better wording? What I'm trying to capture is:
- data "m=" section negotiated for the first time
- data "m=" section going from rejected to non-rejected
- local port changed (which should only happen if this is an answer to a remote offer that changed the port)
There was a problem hiding this comment.
Is it possible to initiate a new SCTP association before setRemoteDescription is called? If the local port and remote port are assumed to be the same, I guess it is, but otherwise you need the remote port provided by setRemoteDescription.
There was a problem hiding this comment.
Is it possible to initiate a new SCTP association before setRemoteDescription is called?
Yeah, "initiate" doesn't quite work either, especially given that SCTP uses an "INIT" message.
I'd like to not say something as vague as "If the description is associated with a new SCTP association"... How about "If the description will lead to a new SCTP association being established?"
Another option would be to only create a new object when applying an answer or pr-answer. The more I think about it, the more that seems like the more correct thing to do. For one, how is "maxMessageSize" set without any remote description?
There was a problem hiding this comment.
If the SctpTransport is created when calling setLocalDescription then maxMessageSize needs to be nullable since it will be null prior to setting a remote description. Perhaps a state attribute would clarify whether the SctpTransport was new, connecting, connected or closed.
This simplifies things, and means we don't need to make maxMessageSize nullable. Also, started referencing the specific sections of sctp-sdp that deal with this, and changed "closes/establishes" to "initiates the closure"/ "initiates the establishment", which is more accurate.
|
LGTM |
Fixes #979.
An SctpTransport represents a unique SCTP association. It's created from
applying a local description, and set to null when applying an answer
with a rejected data m= section.
SCTP-SDP reference will be added by this PR: tobie/specref#327