Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stats need to mark up which members are required #304

Closed
alvestrand opened this issue Jan 23, 2018 · 3 comments · Fixed by #569
Closed

Stats need to mark up which members are required #304

alvestrand opened this issue Jan 23, 2018 · 3 comments · Fixed by #569

Comments

@alvestrand
Copy link
Contributor

Some fields are needed for the stats to make any sense at all. Others may or may not be present, depending on the state of the connection or the quality of the implementation.

Those that are absolutely necessary should be marked up with "required" in the IDL.

@alvestrand
Copy link
Contributor Author

This is entirely orthogonal to the question of whether they're mandatory-to-implement.

@aboba
Copy link
Contributor

aboba commented Nov 14, 2019

@alvestrand Can we get a PR to close this issue since it is blocking issuance of the CR?

@alvestrand
Copy link
Contributor Author

I think we can safely remove the CR-blocker label. Doing this at a later stage is not a breaking change, it's just improved documentation.

@henbos henbos removed the CR blocker label Nov 15, 2019
alvestrand added a commit that referenced this issue Apr 21, 2020
alvestrand added a commit that referenced this issue Apr 23, 2020
alvestrand added a commit that referenced this issue Apr 23, 2020
* Add "required" specifiers within dictionaries

Fixes #304
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants