Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identifier ambiguity in stat objects #350

Closed
balazskreith opened this issue May 18, 2018 · 1 comment
Closed

Identifier ambiguity in stat objects #350

balazskreith opened this issue May 18, 2018 · 1 comment

Comments

@balazskreith
Copy link
Contributor

balazskreith commented May 18, 2018 •
edited
Loading

Hello,

Recently we have created a graph to have an overview how we can reach one webrtc stat object from another one (See the attachment). We used the names listed in the RTCStatsType to identify attributes in other objects pointing to another stat object. This works quite well, except (as far as I see) for transportId.
I have found that transportId points to RTCTransportStats in all appearances except in RTCIceCandidateStats where transportId points to RTCIceCandidateStats.
Is there a special reason for that, or may we ask to avoid ambiguity and came up with a better name, for an instance: candidateId?

Attachment:
webrtcStats.gv.pdf
taylor-b added a commit to taylor-b/webrtc-stats that referenced this issue May 18, 2018
@taylor-b
Fixing some descriptions of ID references between stats objects.
39f6590 
Fixes w3c#350

- RTCIceCandidateStats.transportId is the ID of an RTCTransportStats,
  not another RTCIceCandidateStats
- RTCIceCandidatePairStats.localCandidateId and remoteCandidateId are
  IDs of RTCIceCandidateStats, not RTCIceCandidateAttributes (there's
  no such thing).
@taylor-b
Copy link
Contributor

That was just a typo on my part. I'll fix it.

@taylor-b taylor-b mentioned this issue May 18, 2018
Merged
vr000m pushed a commit that referenced this issue May 19, 2018
@taylor-b @vr000m
Fixing some descriptions of ID references between stats objects. (#351)
f54b047 
Fixes #350

- RTCIceCandidateStats.transportId is the ID of an RTCTransportStats,
  not another RTCIceCandidateStats
- RTCIceCandidatePairStats.localCandidateId and remoteCandidateId are
  IDs of RTCIceCandidateStats, not RTCIceCandidateAttributes (there's
  no such thing).
@alvestrand alvestrand mentioned this issue May 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@balazskreith @taylor-b