Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impact on Track Stats because of moving stats from sender/receiver to appropriate in/outbound rtp #403

Closed
vr000m opened this issue Mar 6, 2019 · 6 comments
Assignees

Comments

@vr000m
Copy link
Contributor

vr000m commented Mar 6, 2019

Related #402.

@vr000m
Copy link
Contributor Author

vr000m commented Mar 6, 2019

@pallab-gain @karthikbr82 could you make sure that the tracks have the right stats once @henbos makes the appropriate changes to RTC[In/Out]boundRtpStreamStats

@vr000m
Copy link
Contributor Author

vr000m commented Jul 24, 2019

We probably to discuss replaceTrack and onstatsended but also to discuss if the trackattachment stats are needed and instead rely on track stats.

cc: @henbos @pallab-gain @karthikbr82

@henbos
Copy link
Collaborator

henbos commented Jul 24, 2019

If "onstatsended" fires for the track attachment we could do getStats() to get outbound-rtp values at the time of the event, though it wouldn't be a perfect snapshot because the counters in the outbound-rtp might keep increasing.

@henbos
Copy link
Collaborator

henbos commented Jul 24, 2019

Let's discuss further when #463 has landed

@henbos
Copy link
Collaborator

henbos commented Aug 29, 2019

#463 has landed

@henbos
Copy link
Collaborator

henbos commented Aug 29, 2019

I just filed #479 arguing for the removal of these dictionaries. I think "what to do about onstatsended?" should be discussed in a separate issue, so I filed #480.

With those two issues, I think we can close this issue as having been split up into two issues. Feel free to object.

@henbos henbos closed this as completed Aug 29, 2019
@henbos henbos removed the TPAC 2019 label Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants