Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type stunserverconnection should be stun-server-connection #444

Closed
henbos opened this issue Jun 13, 2019 · 2 comments · Fixed by #493
Closed

Type stunserverconnection should be stun-server-connection #444

henbos opened this issue Jun 13, 2019 · 2 comments · Fixed by #493
Assignees
@vr000m
Labels
Ready for PR

Comments

@henbos
Copy link
Collaborator

henbos commented Jun 13, 2019

For consistency with other types (e.g. local-candidate, not localcandidate).
@fippo
Copy link
Contributor

fippo commented Jun 13, 2019

can the name be changed to something less "ugly" as well? ice-server for consistency with RTCIceServer, dropping the "connection" because when running over udp there is no connection?

@vr000m
Copy link
Contributor

vr000m commented Jun 14, 2019

@lennart-csio PTAL

@vr000m vr000m assigned vr000m and unassigned vr000m Sep 4, 2019
@vr000m vr000m assigned vr000m and unassigned vr000m Sep 16, 2019
lennart-csio added a commit to lennart-csio/webrtc-stats that referenced this issue Sep 16, 2019
@lennart-csio
issue w3c#444
9e603a3
@lennart-csio lennart-csio mentioned this issue Sep 16, 2019
Merged
vr000m pushed a commit that referenced this issue Sep 16, 2019
@lennart-csio @vr000m
ice-server instead of stunserverconnection (#493)
0b67d98 
* issue #444

* editor removed whitespaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vr000m vr000m

Labels
Ready for PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ice-server instead of stunserverconnection lennart-csio/webrtc-stats
3 participants
@fippo @vr000m @henbos