Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New metric to report minimum jitter buffer delay #634

Closed
ivocreusen opened this issue Jun 2, 2022 · 4 comments
Closed

New metric to report minimum jitter buffer delay #634

ivocreusen opened this issue Jun 2, 2022 · 4 comments

Comments

@ivocreusen
Copy link
Contributor

There are various reasons why the jitter buffer delay might be increased to a higher value, such as to achieve AV sync or because a playoutDelay was set on a RTCRtpReceiver (see https://w3c.github.io/webrtc-extensions/#dom-rtcrtpreceiver-playoutdelay). When using one of these mechanisms, it can be useful to keep track of the minimal jitter buffer delay that could have been achieved, so WebRTC clients can track the amount of extra delay that is being added.

I would like to propose a new stat to track this minimum achievable jitter buffer delay. This stat should work similar to RTCInboundRtpStreamStats.jitterBufferTargetDelay, except that it should not be affected by playoutDelay (see link above) or AV sync or any other mechanisms. The metric should be purely based on the network characteristics such as jitter and packet loss. A proposal for a name is RTCInboundRtpStreamStats.estimatedMinimumJitterBufferTargetDelay

@henbos
Copy link
Collaborator

henbos commented Jun 3, 2022

Makes sense, can you write a pull request?

We're currently in the process of moving unimplemented metrics to webrtc-provisional-stats but if you intend to also implement it, adding it to webrtc-stats still makes sense. We want all metrics in this doc to have at least one implementation.

ivocreusen pushed a commit to ivocreusen/webrtc-stats that referenced this issue Jun 15, 2022
henbos pushed a commit that referenced this issue Jun 29, 2022
* Add estimatedMinimumJitterBufferTargetDelay metric (#634)

* Review comments. Metric is renamed to jitterBufferMinimumDelay, and the description mentions it is updated at the same time as jitterBufferEmittedCount

Co-authored-by: Ivo Creusen <ivoc@google.com>
@henbos
Copy link
Collaborator

henbos commented Jun 30, 2022

The PR to add jitterBufferMinimumDelay merged yesterday but the spec still does not have it...? @dontcallmedom

@henbos
Copy link
Collaborator

henbos commented Jun 30, 2022

"Latest editor's draft" points to a June 14 version

@henbos
Copy link
Collaborator

henbos commented Jun 30, 2022

I filed #646 to follow up on this, I think we can close this issue in the meantime since I can confirm that jitterBufferMinimumDelay exists on tip of tree

@henbos henbos closed this as completed Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants