New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jitterBufferMinimumDelay metric #641
Conversation
@ivocreusen is a Googler (ivoc@), how do we make the bot recognize this? |
Never mind, I was able to re-run the IPR check and it is happy now |
as jitter and packet loss, and can be seen as the minimum obtainable jitter buffer delay if no | ||
external factors would affect it. | ||
</p> | ||
</dd> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we explicitly state that the metric is updated every time the jitterBufferEmittedCount
is updated. This is the jitter buffer delay if there was no reason for holding the sample or frame for application related reasons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would CPU issues cause this metric to be updated or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the description to mention it is updated whenever jitterBufferEmittedCount
is updated. About CPU issues: I don't think CPU issues should affect the metric, but then again it is hard to predict exactly what happens when there is a CPU issue so I am not sure if we should give any explicit guarantees about that in the standards description.
left comments inline. Renaming the metric to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small changes, then go ahead and merge in this spec or provisional depending on implementation status
I'll coordinate with ivoc to get this merged here or in provisional depending on implementation commitment and addressing comments |
He'll get to this and the implementation in a few weeks, putting the editors can integrate label in the meantime |
…he description mentions it is updated at the same time as jitterBufferEmittedCount
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, let's merge!
Preview | Diff