Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction to RTP stream statistics #291

Merged
merged 2 commits into from
Jan 10, 2018
Merged

Introduction to RTP stream statistics #291

merged 2 commits into from
Jan 10, 2018

Conversation

alvestrand
Copy link
Contributor

Added a hierarchical explainer for what the different
dictionaries in the hierarchy do. Should be reviewed after formatting!

Added a hierarchical explainer for what the different
dictionaries in the hierarchy do. Should be reviewed after formatting!
@vr000m
Copy link
Contributor

vr000m commented Jan 10, 2018

While reviewing the document earlier, I was thinking about swapping the order, starting with sent streams and then receiving streams... but we can do this later once all the CR blockers are done..

Copy link
Contributor

@vr000m vr000m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits, otherwise ready merge.

<p><a>RTCReceivedRTPStreamStats</a>: Stats measured at
the receiving end of an RTP stream, known
either because they're measured locally or transmitted
via RTCP.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/via RTCP/via an RTCP RR or RTCP XR

<a>RTCRemoteInboundRTPStreamStats</a>: Stats
relevant to the remote receiving
end of an RTP stream - usually computed by combining local
data with data received via RTCP receiver reports.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

via RTCP Receiver Reports (RR) and RTCP Extended Reports (XR).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added both, did long version first.

@alvestrand
Copy link
Contributor Author

Harald will fix and merge.

@alvestrand alvestrand merged commit 4998543 into master Jan 10, 2018
@vr000m vr000m deleted the rtp-hierarchy branch January 11, 2018 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants