fix rtcicecandidate url description #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-ivar
approved these changes
Sep 12, 2018
webrtc-stats.html
Outdated
| <code>RTCPeerConnectionIceEvent</code>. | ||
| For local candidates this is the URL of the ICE server from | ||
| which the candidate was obtained. It is the same as the | ||
| <code>url</code> surfaced in the |
There was a problem hiding this comment.
Please link to http://w3c.github.io/webrtc-pc/#dom-rtcpeerconnectioniceevent-url otherwise we get a markup loop.
also restrict it to local candidates
fippo
force-pushed
the
the-that-what-the-heck
branch
from
e816770
to
b058edc
Compare
jan-ivar
reviewed
Sep 12, 2018
webrtc-stats.html
Outdated
| <a href="https://w3c.github.io/webrtc-pc/#rtcpeerconnectioniceevent">url surfaced in the RTCPeerConnectionIceEvent</a>. | ||
| </p> | ||
| <p> | ||
| For remote candidates, this property is not applicable. |
There was a problem hiding this comment.
Can we s/applicable/present/ ? Present has specific meaning.
There was a problem hiding this comment.
will change in both places
There was a problem hiding this comment.
hrm:
When a feature is not applicable to an instance of an object (for example audioLevel
on a video stream), omit the dictionary member. Do NOT report a count of zero, -1 or
"empty string".
We use "applicable" four times (up from 3).
We do not use it for things like pliCount.
Keep as is an file an issue to be more consistent?
|
changed "not applicable" which is not used in many places. The usage of "applicable" is not consistent anyway, see e.g. pliCount |
|
I will open another issue for not applicable/not present. Otherwise LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also restrict it to local candidates