Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix rtcicecandidate url description #368

Merged
merged 2 commits into from
Oct 11, 2018
Merged

fix rtcicecandidate url description #368

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b058edc
fix rtcicecandidate url description
fippo Sep 12, 2018
2bb324b
rtcicecandidate: change not-applicable to not-present
fippo Sep 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions webrtc-stats.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3016,9 +3016,12 @@ <h2>
</dt>
<dd>
<p>
The URL of the TURN or STUN server indicated in the that translated this IP
address. It is the URL address surfaced in an
<code>RTCPeerConnectionIceEvent</code>.
For local candidates this is the URL of the ICE server from
fippo marked this conversation as resolved.
Show resolved Hide resolved
which the candidate was obtained. It is the same as the
<a href="https://w3c.github.io/webrtc-pc/#rtcpeerconnectioniceevent">url surfaced in the RTCPeerConnectionIceEvent</a>.
</p>
<p>
For remote candidates, this property is not applicable.
Copy link
Member

@jan-ivar jan-ivar Sep 12, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we s/applicable/present/ ? Present has specific meaning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will change in both places

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hrm:

When a feature is not applicable to an instance of an object (for example audioLevel
          on a video stream), omit the dictionary member. Do NOT report a count of zero, -1 or
          "empty string".

We use "applicable" four times (up from 3).
We do not use it for things like pliCount.

Keep as is an file an issue to be more consistent?

</p>
</dd>
<dt>
Expand Down