-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify SendStream algorithms #283
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricea
reviewed
Jun 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to use whatwg/streams#1132 once it is landed.
This was referenced Jun 16, 2021
vasilvv
reviewed
Jun 21, 2021
jan-ivar
approved these changes
Jun 22, 2021
vasilvv
approved these changes
Jun 22, 2021
- Specify write, close and abort algorithms for SendStream. - Specify the behavior for STOP_SENDING signal. This is for #185. Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
yutakahirano
force-pushed
the
yhirano/send-stream
branch
from
June 23, 2021 03:48
6f1646d
to
f74a12c
Compare
github-actions bot
added a commit
that referenced
this pull request
Jun 23, 2021
SHA: 2a9c6eb Reason: push, by @yutakahirano Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
yutakahirano
pushed a commit
that referenced
this pull request
Jun 23, 2021
Let's use "incoming unidirectional" and "outgoing unidirectional" instead of "incoming" and "outgoing" for WebTransport stream. This is a follow-up of #283.
yutakahirano
added a commit
that referenced
this pull request
Jun 25, 2021
Let's use "incoming unidirectional" and "outgoing unidirectional" instead of "incoming" and "outgoing" for WebTransport stream. This is a follow-up of #283.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for #185.
Fixes #259.
Preview | Diff