Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify SendStream algorithms #283

Merged
merged 3 commits into from
Jun 23, 2021
Merged

Specify SendStream algorithms #283

merged 3 commits into from
Jun 23, 2021

Conversation

yutakahirano
Copy link
Contributor

@yutakahirano yutakahirano commented Jun 16, 2021

  • Specify write, close and abort algorithms for SendStream.
  • Specify the behavior for STOP_SENDING signal.

This is for #185.
Fixes #259.


Preview | Diff

@yutakahirano
Copy link
Contributor Author

@vasilvv @jan-ivar @ricea can you take a look?

Copy link
Contributor

@ricea ricea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to use whatwg/streams#1132 once it is landed.

index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
index.bs Outdated Show resolved Hide resolved
 - Specify write, close and abort algorithms for SendStream.
 - Specify the behavior for STOP_SENDING signal.

This is for #185.

Co-authored-by: Jan-Ivar Bruaroey <jan-ivar@users.noreply.github.com>
Yutaka Hirano added 2 commits June 23, 2021 12:50
@yutakahirano yutakahirano merged commit 2a9c6eb into main Jun 23, 2021
@yutakahirano yutakahirano deleted the yhirano/send-stream branch June 23, 2021 03:52
github-actions bot added a commit that referenced this pull request Jun 23, 2021
SHA: 2a9c6eb
Reason: push, by @yutakahirano

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
yutakahirano pushed a commit that referenced this pull request Jun 23, 2021
Let's use "incoming unidirectional" and "outgoing unidirectional"
instead of "incoming" and "outgoing" for WebTransport stream.

This is a follow-up of #283.
yutakahirano added a commit that referenced this pull request Jun 25, 2021
Let's use "incoming unidirectional" and "outgoing unidirectional"
instead of "incoming" and "outgoing" for WebTransport stream.

This is a follow-up of #283.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should writable.close wait for all the data to be sent to the peer?
4 participants