Skip to content

Commit

Permalink
Merge pull request #28 from foolip/enum-syntax-error
Browse files Browse the repository at this point in the history
Make VTTRegion.scroll an enum ScrollSetting

Remove dead code throwing SyntaxError in enum setters
https://www.w3.org/Bugs/Public/show_bug.cgi?id=22967
https://www.w3.org/Bugs/Public/show_bug.cgi?id=22968
  • Loading branch information
silviapfeiffer committed Jan 29, 2014
2 parents e06d064 + 275ff3e commit 06e9e20
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions webvtt.html
Original file line number Diff line number Diff line change
Expand Up @@ -5251,8 +5251,7 @@ <h3>VTTCue interface</h3>

<p>On setting, the <a>text track cue writing direction</a> must be set to the value given in
the first cell of the row in the table above whose second cell is a <a>case-sensitive</a>
match for the new value, if any. If none of the values match, then the user agent must instead
throw a <code>SyntaxError</code> exception.</p>
match for the new value.</p>

<p>The <dfn title="dom-VTTCue-snapToLines"><code>snapToLines</code></dfn> attribute, on
getting, must return true if the <a>text track cue snap-to-lines flag</a> of the <a>text
Expand Down Expand Up @@ -5285,8 +5284,7 @@ <h3>VTTCue interface</h3>

<p>On setting, the <a>text track cue line alignment</a> must be set to the value given in the
first cell of the row in the table above whose second cell is a <a>case-sensitive</a> match
for the new value, if any. If none of the values match, then the user agent must instead throw a
<code>SyntaxError</code> exception.</p>
for the new value.</p>

<p>The <dfn title="dom-VTTCue-position"><code>position</code></dfn> attribute, on getting,
must return the <a>text track cue text position</a> of the <a>text track cue</a> that
Expand All @@ -5312,8 +5310,7 @@ <h3>VTTCue interface</h3>

<p>On setting, the <a>text track cue text position alignment</a> must be set to the value given in the
first cell of the row in the table above whose second cell is a <a>case-sensitive</a> match
for the new value, if any. If none of the values match, then the user agent must instead throw a
<code>SyntaxError</code> exception.</p>
for the new value.</p>

<p>The <dfn title="dom-VTTCue-size"><code>size</code></dfn> attribute, on getting, must
return the <a>text track cue size</a> of the <a>text track cue</a> that the
Expand All @@ -5339,8 +5336,7 @@ <h3>VTTCue interface</h3>

<p>On setting, the <a>text track cue text alignment</a> must be set to the value given in the
first cell of the row in the table above whose second cell is a <a>case-sensitive</a> match
for the new value, if any. If none of the values match, then the user agent must instead throw a
<code>SyntaxError</code> exception.</p>
for the new value.</p>

<p>The <dfn title="dom-VTTCue-text"><code>text</code></dfn> attribute, on getting, must
return the raw <a>text track cue text</a> of the <a>text track cue</a> that the
Expand Down Expand Up @@ -5414,6 +5410,7 @@ <h3>VTTRegion interface</h3>
<p>The following interface is used to expose WebVTT regions in the DOM API:</p>

<pre class="idl_whatwg">
enum <dfn>ScrollSetting</dfn> { "" /* none */, "up" };
[Constructor]
interface <dfn>VTTRegion</dfn> {
readonly attribute TextTrack? <a title="dom-VTTRegion-track">track</a>;
Expand All @@ -5424,7 +5421,7 @@ <h3>VTTRegion interface</h3>
attribute double <a title="dom-VTTRegion-regionAnchorY">regionAnchorY</a>;
attribute double <a title="dom-VTTRegion-viewportAnchorX">viewportAnchorX</a>;
attribute double <a title="dom-VTTRegion-viewportAnchorY">viewportAnchorY</a>;
attribute DOMString <a title="dom-VTTRegion-scroll">scroll</a>;
attribute <a>ScrollSetting</a> <a title="dom-VTTRegion-scroll">scroll</a>;
};</pre>

<dl class="domintro">
Expand Down Expand Up @@ -5539,7 +5536,7 @@ <h3>VTTRegion interface</h3>
<td> "<code>up</code>"
</table>

<p>On setting, the <a>text track region scroll</a> must be set to the value given on the first cell of the row in the table above whose second cell is a <a>case-sensitive</a> match for the new value, if any. If none of the values match, then the user agent must instead throw a <code>SyntaxError</code> exception.</p>
<p>On setting, the <a>text track region scroll</a> must be set to the value given on the first cell of the row in the table above whose second cell is a <a>case-sensitive</a> match for the new value.</p>

</section><!-- end VTTRegion object -->

Expand Down Expand Up @@ -5740,6 +5737,7 @@ <h2 class="no-num">Acknowledgements</h2> <!-- ACKS -->
<p>Thanks to the many contributors to the HTML standard at the WHATWG and W3C HTML Working Group, where WebVTT was originally specified. <a href="#refsHTML">[HTML]</a>, <a href="#refsHTML5">[HTML5]</a></p>

<p>Thanks to the following active contributors to this spec:
Glenn Adams,
Victor C&#259;rbune,
Eric Carlson,
Anna Cavender,
Expand Down

0 comments on commit 06e9e20

Please sign in to comment.