Remove dead code throwing SyntaxError in enum setters #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviapfeiffer
added a commit
that referenced
this pull request
Jan 29, 2014
Make VTTRegion.scroll an enum ScrollSetting Remove dead code throwing SyntaxError in enum setters https://www.w3.org/Bugs/Public/show_bug.cgi?id=22967 https://www.w3.org/Bugs/Public/show_bug.cgi?id=22968
webkit-commit-queue
pushed a commit
to cola119/WebKit
that referenced
this pull request
Sep 9, 2023
…stead of throwing SyntaxError https://bugs.webkit.org/show_bug.cgi?id=261310 Reviewed by Eric Carlson. The spec that VTTRegion::setScroll throws a SyntaxError in dead code has been removed at w3c/webvtt#28, and now it should ignore assignment of an invalid string. WebKit is failing the corresponding WPT: https://wpt.fyi/results/webvtt/api/VTTRegion/scroll.html?label=experimental&label=master&aligned&q=webvtt * LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/constructor-expected.txt: * LayoutTests/imported/w3c/web-platform-tests/webvtt/api/VTTRegion/scroll-expected.txt: * LayoutTests/media/track/regions-webvtt/vtt-region-constructor-expected.txt: * Source/WebCore/html/track/VTTRegion.cpp: (WebCore::VTTRegion::setScroll): * Source/WebCore/html/track/VTTRegion.h: Canonical link: https://commits.webkit.org/267828@main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.