Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linepos can be the floating value #307

Closed
alastor0325 opened this issue Jun 23, 2016 · 9 comments
Closed

Linepos can be the floating value #307

alastor0325 opened this issue Jun 23, 2016 · 9 comments
Assignees
@zcorpan

Comments

@alastor0325
Copy link
Collaborator

From comment in web-platform-tests.

If linepos contains any characters other than U+002D HYPHEN-MINUS characters (-) and ASCII digits, then jump to the step labeled next setting.

We should make the parser rule and DOM API consistent, to accept the floating value when parsing the linepos value.
@zcorpan
Copy link
Member

zcorpan commented Jun 23, 2016

I'm OK with this. But I think we should keep the conforming syntax as is -- it is an authoring mistake to not use an integer here.

@alastor0325
Copy link
Collaborator Author

Sorry, I don't understand your comment very well :(

I think we should keep the conforming syntax as is -- it is an authoring mistake to not use an integer here.

Does it mean we should keep the original description or ....?

Thanks!

@zcorpan
Copy link
Member

zcorpan commented Jun 27, 2016

I mean I'm OK with changing the parser rules to accept line:1.5, but we should keep the current syntax rules so that a webvtt validator will complain about it.

@alastor0325
Copy link
Collaborator Author

So... you means we shouldn't modify the spec now, but change the test of the web-platform-test to allow line:1.5.
Do I understand correctly?
Thanks!

@zcorpan
Copy link
Member

zcorpan commented Jun 28, 2016

No. 😊

The spec has two sections:
https://w3c.github.io/webvtt/#syntax - this defines how to write a conforming WebVTT file.
https://w3c.github.io/webvtt/#parsing - this defines how to parse anything as WebVTT (whether it is conforming or not).

There is no implied relationship between what is conforming syntax and how you are required to parse it. (c.f. lack of whitespace between cues.)

I am OK with changing the parsing rules (and the tests), but not the syntax section.

I don't know how to make this clearer. Feel free to jump in on IRC if you want to chat.

@alastor0325
Copy link
Collaborator Author

Thanks for explanation!!!

I were confused because the syntax part about line doesn't need to be changed since it has already allowed any floating value, is that right?

Or to represent a line number
1.Optionally a U+002D HYPHEN-MINUS character (-).
2.One or more ASCII digits.

Therefore, if we could change the parsing rule, could you help me to modify it?
And I would send PR after I modified the test.

Thanks again :)

@zcorpan
Copy link
Member

zcorpan commented Jun 29, 2016

ASCII digits is 0-9 but does not include "."

zcorpan added a commit that referenced this issue Jun 29, 2016
@zcorpan
Change parsing of 'line' setting to accept non-integers
25e47ce 
Non-integers can already enter the data model via the DOM API.
However, a valid WebVTT file can still only use integers.

Fixes #307.
@zcorpan zcorpan self-assigned this Jun 29, 2016
@zcorpan zcorpan mentioned this issue Jun 29, 2016
Merged
@alastor0325
Copy link
Collaborator Author

Ok, Thanks!
Close this bug because it would be fixed in #308.

zcorpan added a commit that referenced this issue Jul 1, 2016
@zcorpan
Change parsing of 'line' setting to accept non-integers
023f662 
Non-integers can already enter the data model via the DOM API.
However, a valid WebVTT file can still only use integers.

Fixes #307.
@zcorpan
Copy link
Member

zcorpan commented Jul 1, 2016

No need to close in the future; issues are closed automatically when the PR is merged. 😊

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jul 12, 2016
@alastor0325
Bug 1278748 - part5 : the value of position and line are double. r=ri…
db86aaf 
…llian

Spec parsing rule : https://w3c.github.io/webvtt/#cue-timings-and-settings-parsing
Spec issue : w3c/webvtt#307 (comment), web-platform-tests/wpt#3222

MozReview-Commit-ID: 9ONE7r1fvlD

--HG--
extra : rebase_source : 7d80d231e916b2f439801b4868d929cb2d455971
jostw pushed a commit to jostw/gecko that referenced this issue Jul 13, 2016
@alastor0325
Bug 1278748 - part5 : the value of position and line are double. r=ri…
48d28e4 
…llian

Spec parsing rule : https://w3c.github.io/webvtt/#cue-timings-and-settings-parsing
Spec issue : w3c/webvtt#307 (comment), web-platform-tests/wpt#3222

MozReview-Commit-ID: 9ONE7r1fvlD
jryans pushed a commit to jryans/gecko-dev that referenced this issue Jul 15, 2016
@alastor0325
Bug 1278748 - part5 : the value of position and line are double. r=ri…
00f4820 
…llian

Spec parsing rule : https://w3c.github.io/webvtt/#cue-timings-and-settings-parsing
Spec issue : w3c/webvtt#307 (comment), web-platform-tests/wpt#3222

MozReview-Commit-ID: 9ONE7r1fvlD
jgraham pushed a commit to web-platform-tests/wpt that referenced this issue Aug 1, 2016
@alastor0325 @jgraham
part5 : the value of position and line are double.
913fb77 
Spec parsing rule : https://w3c.github.io/webvtt/#cue-timings-and-settings-parsing
Spec issue : w3c/webvtt#307 (comment), #3222

MozReview-Commit-ID: 9ONE7r1fvlD

Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1278748
@jgraham jgraham mentioned this issue Aug 1, 2016
Merged
ddorwin pushed a commit to ddorwin/web-platform-tests that referenced this issue Sep 13, 2016
@alastor0325 @ddorwin
part5 : the value of position and line are double.
7c6ccf7 
Spec parsing rule : https://w3c.github.io/webvtt/#cue-timings-and-settings-parsing
Spec issue : w3c/webvtt#307 (comment), web-platform-tests#3222

MozReview-Commit-ID: 9ONE7r1fvlD

Upstreamed from https://bugzilla.mozilla.org/show_bug.cgi?id=1278748
@zcorpan zcorpan mentioned this issue Mar 7, 2017
Merged
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Sep 30, 2019
@marco-c
Bug 1278748 - part5 : the value of position and line are double. r=ri…
7137f78 
…llian

Spec parsing rule : https://w3c.github.io/webvtt/#cue-timings-and-settings-parsing
Spec issue : w3c/webvtt#307 (comment), web-platform-tests/wpt#3222

MozReview-Commit-ID: 9ONE7r1fvlD

UltraBlame original commit: 2905747bae6e0093a5ad9fd285c6ba8649523acf
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Sep 30, 2019
@marco-c
Bug 1278748 - part5 : the value of position and line are double. r=ri…
ddeb90d 
…llian

Spec parsing rule : https://w3c.github.io/webvtt/#cue-timings-and-settings-parsing
Spec issue : w3c/webvtt#307 (comment), web-platform-tests/wpt#3222

MozReview-Commit-ID: 9ONE7r1fvlD

UltraBlame original commit: 2905747bae6e0093a5ad9fd285c6ba8649523acf
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Sep 30, 2019
@marco-c
Bug 1278748 - part5 : the value of position and line are double. r=ri…
5954708 
…llian

Spec parsing rule : https://w3c.github.io/webvtt/#cue-timings-and-settings-parsing
Spec issue : w3c/webvtt#307 (comment), web-platform-tests/wpt#3222

MozReview-Commit-ID: 9ONE7r1fvlD

UltraBlame original commit: 2905747bae6e0093a5ad9fd285c6ba8649523acf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zcorpan zcorpan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zcorpan @alastor0325