Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "middle" to "center" throughout for consistency with CSS #244

Merged
merged 1 commit into from
Dec 4, 2015

Conversation

zcorpan
Copy link
Member

@zcorpan zcorpan commented Nov 5, 2015

This affects align, position align, line align, and the DOM API.

Fixes https://www.w3.org/Bugs/Public/show_bug.cgi?id=25956.

@zcorpan
Copy link
Member Author

zcorpan commented Nov 6, 2015

cc @eric-carlson @RickEyre @foolip

@foolip
Copy link
Member

foolip commented Nov 6, 2015

Since I filed the bug, it should come as not surprise that I support this. I've skimmed the diff and assume it's just search+replace, so 👍

@zcorpan
Copy link
Member Author

zcorpan commented Nov 16, 2015

It's search+replace but I sanity-checked each instance in doing so.

I'd like a 👍 from @eric-carlson or @RickEyre (or other active implementor) before merging this.

@zcorpan zcorpan merged commit 3e6dbb7 into gh-pages Dec 4, 2015
@zcorpan zcorpan deleted the align-center branch December 4, 2015 08:28
@eric-carlson
Copy link

👍 from me. Thanks Simon!

@zcorpan
Copy link
Member Author

zcorpan commented Dec 4, 2015

Great, thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants