Fix #227: Explain how bidi works in WebVTT #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM - I like the examples inline, though mostly we've been doing them at the beginning this far. |
Add lots of notes and examples related to bidi issues. Also change the style of sample cue rendering to make it stand out more. The text is partially based on Richard Ishida's text in #227 (comment).
zcorpan
force-pushed
the
clarify-direction
branch
from
2e59de5
to
4a3fef7
Compare
zcorpan
added a commit
that referenced
this pull request
Nov 16, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add lots of notes and examples related to bidi issues. Also change
the style of sample cue rendering to make it stand out more.
The text is partially based on Richard Ishida's text in
#227 (comment).