Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update region lines parsing to round to +/- MAX_VALUE #470

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update region lines parsing to round to +/- MAX_VALUE #470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 13 additions & 1 deletion index.bs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2859,7 +2859,19 @@ Objects</a>.</p>

<li><p>Interpret |value| as an integer, and let |number| be that number.</p></li>

<li><p>Let |region|'s <a>WebVTT region lines</a> be |number|.</p></li>
<li><p><i>Conversion</i>: Let <var>S</var> be the set of finite IEEE 754 double-precision
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's likely we don't need this conversion label

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be useful if we need to do this conversion elsewhere as well. Might be worth checking.

floating-point values except −0, but with two special values added:
<var>2<sup>1024</sup></var> and <var>−2<sup>1024</sup></var>.</p></li>

<li><p>Let |rounded-number| be the number in |S| that is closest to |number|,
selecting the number with an even significand if there are two equally close
values. (The two special values <var>2<sup>1024</sup></var> and <var>−2<sup>1024</sup></var>
are considered to have even significands for this purpose.)</p>

<li><p>If |rounded-number| is <var>2<sup>1024</sup></var> or <var>−2<sup>1024</sup></var>,
jump to the step labeled <i>next setting</i></p></li>

<li><p>Let |region|'s <a>WebVTT region lines</a> be |rounded-number|.</p></li>
</ol>
</dd>

Expand Down