Update region lines parsing to round to +/- MAX_VALUE #470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkatsev
commented
Jul 15, 2019
| @@ -2852,7 +2852,19 @@ Objects</a>.</p> | |||
|
|
|||
| <li><p>Interpret |value| as an integer, and let |number| be that number.</p></li> | |||
|
|
|||
| <li><p>Let |region|'s <a>WebVTT region lines</a> be |number|.</p></li> | |||
| <li><p><i>Conversion</i>: Let <var>S</var> be the set of finite IEEE 754 double-precision | |||
There was a problem hiding this comment.
It's likely we don't need this conversion label
There was a problem hiding this comment.
It may be useful if we need to do this conversion elsewhere as well. Might be worth checking.
|
I would recommend adding this to the REC branch directly. Then, for the master branch, update Bikeshed in a separate PR before making another PR with updates from the REC. |
silviapfeiffer
approved these changes
Jul 15, 2019
gkatsev
added a commit
to gkatsev/webvtt
that referenced
this pull request
Jul 18, 2019
This was referenced Jul 29, 2019
This was referenced Mar 2, 2021
gkatsev
force-pushed
the
round-region-lines
branch
from
64fb7ee
to
4f11bc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would potentially require an update to the WPT.
The text is borrowed from https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#rules-for-parsing-floating-point-number-values, though, I don't think that it's a great fit here.
I haven't regenerated the index.html yet, will do so after I figure out the process around bikeshed updates.
Fixes #467.
Preview | Diff
Preview | Diff