-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up/expand section 9, fix ExposedThing/ConsumedThing, terminology fixes, spell check #176
Conversation
PLEASE REVIEW. Unfortunately this is not just editorial. Not ready to merge (I need to fix some things in the figures) but the text is ready for review. |
Fixed ExposedThing and ConsumedThing globally, addressing #171, which can be closed if this PR is merged. |
@mmccool Great work.
WoT Servient is called Servient in the terminology section, I suggest to rename and move. |
The text refers to "Thing Directory A" and "Thing Directory B" but these were not labelled in the figure. Fixed.
I will fix the Respec issues. I put some punctuation inside the anchor tags... |
I already fixed it on my branch which I created based on yours. |
Uhmm... we may have fixed the respec issues differently. Also I found one extra untagged version of Servient that I fixed while I was at it. I also see you fixed the chapter structure... I fixed that too. Sorry, I promised to not touch the text, then I did :(. Also I just uploaded fixed pictures which you may or may not have. |
I suggest we keep the term WOT Servient, to be aligned with WoT Client, WoT Server. |
How about I leave things alone for half an hour, let you patch things up, then I will check here again and if you have review comments, I can address them. If you make PRs against my repo I can merge them though. |
Ok |
I agree with WoT Servient as opposed to just Servient, it looks odd next to WoT Server and WoT Client. However... not the most pressing issue. Let's just make an issue and deal with it post-TAG-submission. Although allowing either WoT Servient or Servient is fine, too. |
fixing respec, sections, annex
After merging I checked Respec and the section structure -- both look good. Synonym for WoT Servient is also there. Looks to be in good shape to merge now... waiting for any more specific review comments, though. |
Ready to merge. This WILL require a full review, it's (unfortunately) not just editorial...