Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make XML Binding "planned" #288

Merged
merged 2 commits into from
May 17, 2023
Merged

Make XML Binding "planned" #288

merged 2 commits into from
May 17, 2023

Conversation

egekorkan
Copy link
Contributor

@egekorkan egekorkan commented Apr 26, 2023 •
edited by pr-preview bot
Loading

Given that we have not actually tested it, we should remove the link to it from the main document

Preview | Diff

@netlify
Copy link

netlify bot commented Apr 26, 2023 •
edited
Loading

✅ Deploy Preview for wot-binding-templates ready!

Name Link
🔨 Latest commit 415e006
🔍 Latest deploy log https://app.netlify.com/sites/wot-binding-templates/deploys/644938f769b4d900084ef4b2
😎 Deploy Preview https://deploy-preview-288--wot-binding-templates.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

relu91
relu91 approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, we still need to wrap our heads around how the document structure will look like. Even if it is just an editor's draft I would be happier to mark it as planned to not confuse people.

egekorkan
egekorkan commented Apr 26, 2023
View reviewed changes
index.html Outdated Show resolved Hide resolved
@egekorkan
Copy link
Contributor Author

Call of 26.04:

  • We should not remove the link since there is some work already but make it clear in the link and in the document that it is a work in progress.
  • Due to low participation, we will discuss it next time.

@egekorkan egekorkan merged commit 3a5f652 into main May 17, 2023
@egekorkan egekorkan deleted the egekorkan-patch-1 branch May 17, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@relu91 relu91 relu91 approved these changes

@mjkoster mjkoster Awaiting requested review from mjkoster mjkoster is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egekorkan @relu91