Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add // or /*...*/ to make example be highlighted correctly #1711

Merged
merged 2 commits into from
Oct 19, 2022

Conversation

danielpeintner
Copy link
Contributor

@danielpeintner danielpeintner commented Oct 5, 2022

Makes the examples and code snippets highlight correctly..

There are examples (see Example 35 or Example 41) were I had to add an outer { } to make it a valid JSON. This is not completely correct but I think it is still fine.

fixes #1701


Preview | Diff

Comment on lines +5699 to +5700
"onOff": {
"type": "boolean",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: It fixes also some snippets that were not correct before...

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, however the "with defaults" snippets are still broken, right?

@danielpeintner danielpeintner added the Editorial Issues with no technical impact on implementations label Oct 5, 2022
@danielpeintner
Copy link
Contributor Author

danielpeintner commented Oct 5, 2022

LGTM, however the "with defaults" snippets are still broken, right?

Correct, but it is fixed by #1700

@sebastiankb
Copy link
Contributor

from today's TD call decided to merge

@sebastiankb sebastiankb merged commit 1f7192b into w3c:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Editorial Issues with no technical impact on implementations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax highlighting of examples
3 participants