Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Manual HTTPS tests incorrectly listed as automated tests in manifest #123

Closed
tidoust opened this issue Oct 5, 2016 · 0 comments
Closed

Comments

@tidoust
Copy link
Member

tidoust commented Oct 5, 2016

Manual tests need to end with -manual.[ext]. The convention for HTTPS tests is to end the test file name with a .https.html extension. Manual tests that need to run over HTTPS are thus typically named [testname]-manual.https.html.

Manifest generation incorrectly lists these tests in the testharness section of the manifest.

I think the problem is line 60 in sourcefile.py, which tries to extract manual (or ref) from the filename but ends up with manual.https in this case.

Test files currently affected by this bug:

tidoust added a commit to tidoust/wpt-tools that referenced this issue Oct 5, 2016
Manifest tool missed the `manual` in `mytest-manual.https.html` and thus
incorreclty listed such tests in the automated section of the manifest file.
Ms2ger pushed a commit that referenced this issue Oct 5, 2016
Manifest tool missed the `manual` in `mytest-manual.https.html` and thus
incorreclty listed such tests in the automated section of the manifest file.
@Ms2ger Ms2ger closed this as completed Oct 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants