Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Add the run tests in iframe feature. #33

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

xiuqijix
Copy link

@xiuqijix xiuqijix commented Sep 6, 2015

This change is Reviewable

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/5789

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@xiuqijix xiuqijix changed the title Xiuqi/iframe Add the run tests in iframe feature. Sep 6, 2015
@xiuqijix
Copy link
Author

xiuqijix commented Sep 6, 2015

Add a feature that run tests in iframe by select "Run Tests in "iframe"" checkbox.

@jgraham
Copy link
Member

jgraham commented Nov 30, 2015

Just the top patch here has a handful of trivial issues (see critic) and I would like to merge it if you fix those.

@yugang
Copy link

yugang commented Dec 2, 2015

@jgraham , the first two commits have the same reason here: #31, we just need merge the last one of the four commits.

@xiuqijix
Copy link
Author

xiuqijix commented Dec 8, 2015

@jgraham , the first three commits have the same reason here: #32 .You can merge #33 after #32 , thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants