Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Commit

Permalink
fixup! Add support for different WebDriver servers
Browse files Browse the repository at this point in the history
  • Loading branch information
andreastt committed Dec 5, 2014
1 parent f28ea92 commit 682290c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion wptrunner/browsers/chrome.py
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class ChromeBrowser(Browser):
"""Chrome is backed by chromedriver, which is supplied through
``browsers.webdriver.ChromedriverLocalServer``."""

def __init__(self, logger, binary, webdriver_binary=None):
def __init__(self, logger, binary, webdriver_binary="chromedriver"):
"""Creates a new representation of Chrome. The `binary` argument gives
the browser binary to use for testing."""
Browser.__init__(self, logger)
Expand Down
4 changes: 2 additions & 2 deletions wptrunner/browsers/webdriver.py
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ def stop(self):
class ChromedriverLocalServer(LocalServer):
default_endpoint = "/wd/hub"

def __init__(self, logger, binary=None, port=None, endpoint=None):
LocalServer.__init__(self, logger, binary or "chromedriver", port=port, endpoint=endpoint)
def __init__(self, logger, binary="chromedriver", port=None, endpoint=None):
LocalServer.__init__(self, logger, binary, port=port, endpoint=endpoint)
# TODO: verbose logging
self.cmd = [self.binary,
cmd_arg("port", str(self.port)) if self.port else "",
Expand Down

0 comments on commit 682290c

Please sign in to comment.