This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Fixed regression in config-file reading. #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change causes the `wptcommandline.py` code to once again read the `tests` and `metadata` paths from the `[paths]` section of the `wptrunner.default.ini` config file or other specified config file. (In 8158824 -- specifically in 8158824#diff-409148835eecbf686495abf6ffd37cb5L125 a change was made that regressed config-file reading in such a way as to cause the code to just ignore any `tests` and `metadata` paths specified in the `[paths]` section of the `wptrunner.default.ini` config file or other specified config file.)
|
Critic review: https://critic.hoppipolla.co.uk/r/2981 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
sideshowbarker
referenced
this pull request
Oct 25, 2014
In this design each directory containing tests gets a metadata directory and is mounted somewhere under /. So one might have a set of local tests that are waiting to be upstreamed with a folder structure like local tests metadata Alongside the web-platfrom-tests directory that might look like wpt tests meta web-platform-tests would be mounted at / and local at /_local/. This could be specified in a config.ini file as [manifest:upstream] tests = wpt/tests metadata = wpt/meta url_base = / [manifest:local] tests = local/tests metadata = local/meta url_base = /_outbound/
|
Superseded by #42 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change causes the
wptcommandline.pycode to once again readthe
testsandmetadatapaths from the[paths]section of thewptrunner.default.iniconfig file or other specified config file.(In 8158824 -- specifically in 8158824#diff-409148835eecbf686495abf6ffd37cb5L125
a change was made that regressed config-file reading in such a way as to
cause the code to just ignore any
testsandmetadatapaths specified inthe
[paths]section of thewptrunner.default.iniconfig file or otherspecified config file.)