This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Always close the connection at the end of a request. #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since changing the HTTP version to 1.1, the connection would use keepalive. This is fine in most cases, but some responses don't know how long they are and so don't set Content-Length. This meant that the associated request would time out. Closing the connection fixes this issue. If we need keepalive e.g. to test browser behaviour in this area then we can revisit this fix with something more surgical.
|
Critic review: https://critic.hoppipolla.co.uk/r/1249 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via |
Change to only closing the connection when we don't have a Content-Length header.
jgraham
added a commit
that referenced
this pull request
Apr 15, 2014
Always close the connection at the end of a request.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since changing the HTTP version to 1.1, the connection would use
keepalive. This is fine in most cases, but some responses don't
know how long they are and so don't set Content-Length. This meant
that the associated request would time out. Closing the connection
fixes this issue. If we need keepalive e.g. to test browser behaviour
in this area then we can revisit this fix with something more
surgical.