Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotate threat model headers 45 degrees instead of 90. #30

Merged
merged 1 commit into from Aug 6, 2020

Conversation

jyasskin
Copy link
Member

@jyasskin jyasskin commented May 29, 2020

This should make them somewhat easier to read without losing too much horizontal space.


Preview | Diff

@NalaGinrut
Copy link
Member

@jyasskin Maybe 30 will be better.

Copy link

@hober hober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jyasskin jyasskin merged commit ded6a51 into w3cping:main Aug 6, 2020
@jyasskin jyasskin deleted the table-style branch August 6, 2020 18:13
@jyasskin
Copy link
Member Author

jyasskin commented Aug 6, 2020

@NalaGinrut The 30° rotation would make the titles closer to flat, which probably would improve readability, but would require extra horizontal space to make sure they don't overlap. I suspect that tradeoff isn't worth it, but you could try out the tweak to the constants here and post screenshots to prove me wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants