Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a script to check that cells are under the right headers. #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jyasskin
Copy link
Member

@jyasskin jyasskin commented Jun 4, 2020

Depends on #30, since that changes the structure of the header cells.

It's hard to be sure that the checks and x's keep matching their column headers as the threat-model tables change, since they're far apart in the source, so this script emits console.errors when the local declaration of the goal doesn't match the reader-visible column header.

@tabatkins, FYI in case you see an easy way to surface these errors more visibly or, even better, during the Bikeshed build.


Preview | Diff

@tabatkins
Copy link

Hmm, so a general capability to explicitly tie cells to particular columns, to ensure order doesn't get messed up? Theoretically doable, yeah.

Copy link

@hober hober left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it contains the change from #30 as well, which makes it hard to review.

@jyasskin
Copy link
Member Author

jyasskin commented Aug 6, 2020

Now that #30 is merged, this is back to a single commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants