Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Img decoding attribute #220

Closed
1 of 3 tasks
vmpstr opened this issue Dec 1, 2017 · 7 comments
Closed
1 of 3 tasks

Img decoding attribute #220

vmpstr opened this issue Dec 1, 2017 · 7 comments
Assignees
Labels
Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review

Comments

@vmpstr
Copy link

vmpstr commented Dec 1, 2017

Hello TAG!

I'm requesting a TAG review of:

We'd prefer the TAG provide feedback as (please select one):

  • open issues in our Github repo for each point of feedback
  • open a single issue in our Github repo for the entire review
  • leave review feedback as a comment in this issue and @-notify [github usernames]

Thanks!

/cc: @chrishtr @domenic @smfr

@slightlyoff
Copy link
Member

slightlyoff commented Dec 7, 2017

Looks like there's already an Intent-to-Ship for Chromium: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/MbXp16hQclY/bQjegyrbAgAJ

@cynthia
Copy link
Member

cynthia commented Feb 1, 2018

As a curious question, it seems like there are two modes here being proposed - sync and async - since there is a mechanism that allows an explicit request to decode a certain HTMLImageElement, I'm curious if there should be a "no decode" mode (to save memory, and potentially VRAM in certain cases) for resources that the content developer only would like to have available given that the user triggers a specific view where this image needs to be shown? With decode() (which from what I see has had some debates on whether or not it is the best name, setting that discussion aside) it seems like this would allow placeholding image elements and only decoding them when deemed needed.

As for what has been proposed, I'll have to wait for @dbaron 's feedback on this since he is the assigned reviewer for this.

@plinss plinss modified the milestones: tag-f2f-london-2017-07-25, tag-f2f-london-2018-01-31 Feb 1, 2018
@triblondon
Copy link

Sangwhan agreed to write up the conclusions of our very extensive discussions at London F2F.

@cynthia
Copy link
Member

cynthia commented Feb 2, 2018

This was brought up during the London F2F - we understand the underlying problem this is attempting to address, and believe we are in agreement on the importance giving better control on when and how images are decoded in a document.

That said, we have spent a reasonable time of this during the F2F at great length, and have some concerns on the approach taken here. The approach taken here seems to be intended to address the problem in limited scope for simplicity, where we could be trying to address this in a more extensible way - exposing the primitives surrounding loading, decoding, and eventually rasterizing images in a way that provides the building blocks for developers to define the behavior as they see fit.

The comments above cover the property discussed in this review, but also the decode() API which we have recently done a review on.

@cynthia cynthia added Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review and removed Progress: in progress labels Feb 2, 2018
@dbaron
Copy link
Member

dbaron commented Feb 2, 2018

The decode() review was #182.

Though I'd note the other tradeoff regarding primitives is that there are areas where we'd like to leave room for implementations to optimize, and defining some things to precisely in terms of primitives could constrain that.

@plinss plinss modified the milestones: 2018-02-27-telcon, 2018-03-14-telcon Mar 6, 2018
@torgo
Copy link
Member

torgo commented Mar 13, 2018

@cynthia is going to try to draft a proposal by next week as feedback

@plinss
Copy link
Member

plinss commented Mar 20, 2018

@cynthia to file an issue on the spec

@plinss plinss closed this as completed Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review
Projects
None yet
Development

No branches or pull requests

7 participants