Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MediaStream Image Capture (wide review) #651

Closed
Tracked by #282
caribouW3 opened this issue Jun 22, 2021 · 2 comments
Closed
Tracked by #282

MediaStream Image Capture (wide review) #651

caribouW3 opened this issue Jun 22, 2021 · 2 comments
Assignees
Labels
Resolution: satisfied The TAG is satisfied with this design Topic: media Venue: WebRTC WebRTC and media capture

Comments

@caribouW3
Copy link

Ya ya yawm TAG!

I'm requesting a TAG review of MediaStream Image Capture.

[One paragraph summary of idea, ideally copy-pasted from Explainer introduction]

Cameras on client platforms like mobile devices, tablets and laptops are increasingly adding advanced features. In many cases, users do use external cameras when the inbuilt cameras are not delivering the required experience, say on a video call. This specification exposes some of the advanced photography primitives in a standards compliant manner using media track constraints in MediaDevices.getUserMedia(). For manipulating video related capabilities, current settings and constraints are done via MediaStreamTrack.applyConstraints(). Photo-specific capabilities and current settings can be retrieved via getPhotoCapabilities()/getPhotoSettings() and configured via takePhoto()'s PhotoSettings argument. The produced image can be in the form of a Blob or as a ImageBitmap.

We'd prefer the TAG provide feedback as (please delete all but the desired option): GH issues

🐛 open issues in our GitHub repo for each point of feedback

@plinss
Copy link
Member

plinss commented Jun 29, 2021

I'm wondering why the PhotoSettings passed to takePhoto only allow control over resolution and flash modes. Couldn't some of the other settings potentially be selected only for the photo without changing the underlying stream? e.g. exposure controls, white balance, etc

@torgo torgo added the Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review label Sep 16, 2021
@torgo torgo added Progress: propose closing we think it should be closed but are waiting on some feedback or consensus and removed Progress: pending external feedback The TAG is waiting on response to comments/questions asked by the TAG during the review labels Sep 16, 2021
@atanassov
Copy link

@plinss and I looked at this review again during our Gethen vf2f. We like use cases addressed by this proposed capability and the overall shape of the API. Apart from the one feedback that we cross-posted to your repo we are happy to close the review.

Thank you for working with TAG. We look forward to seeing further progress made with the WebRTC folks.

@atanassov atanassov added Resolution: satisfied The TAG is satisfied with this design and removed Progress: propose closing we think it should be closed but are waiting on some feedback or consensus labels Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: satisfied The TAG is satisfied with this design Topic: media Venue: WebRTC WebRTC and media capture
Projects
None yet
Development

No branches or pull requests

4 participants