-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review Request for prefers-contrast media query #663
Comments
Hi @sartang, similar to other design reviews, can you add an actual explainer to this review? Having well articulated user needs and scenarios, the different approaches you considered and how this proposal addresses these is valuable to the review and for posterity. |
prefers-contrast ExplainerThe MotivationSome users may find it difficult to read text when the foreground to background color contrast ratios are too high or too low. Many operating systems have an underlying method to apply a contrast preference across their system. For example, on Windows, High Contrast can be used to enforce a limited color palette across applications. Although the default themes guarantee a high color contrast between the text and background (>10:1), it is possible for users to customize these colors, which may result in a low contrast preference. On macOS and iOS, users have the option to apply an Increased Contrast mode. Additionally, on Linux, users can make use of High Contrast GTK themes. It is difficult to produce a universal solution that automatically and effectively reflects these contrast preferences on an arbitrary webpage. For instance, consider the case where text is surrounded by a
By exposing the system contrast settings to the authors through the Current design
On MacOS and Linux, we will match Similarly, on Windows, if High Contrast is not enabled, we match Prefers-contrast vs forced-colors
Design considerations
This three-value design, however, was flagged as potentially problematic for Forced Colors Mode users that have a color scheme with contrast ratios which are not considered particularly high or low. More specifically, if an author were to apply styles using the To address this issue initially, However, |
@hober @atanassov - any chance you could review (with the updated explainer) tomorrow? We'd love to be able to check this box off. Thanks! |
Thank you for writing an explainer, @sartang! Could you find a place for it to live that isn't in a comment here, though? As we wrote in the explainer explainer, an "explainer is a living document that describes the current state of your proposed web platform feature." It's relevant to a general audience, not just the TAG. Perhaps it can live in the |
Hi @dlibby-, @atanassov and I looked at this in our F2F today and we're pretty happy with where this has ended up. Thanks for your patience with this review and thanks for all your hard work on this feature! |
Note: we are still waiting for the TAG review to complete (it's been assigned to someone so hopefully not long): w3ctag/design-reviews#663 Bug: 1107431 Change-Id: I6ca24866759fe2d2e602a01934f7ac186ad5cdb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3093026 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Sara Tang <sartang@microsoft.com> Cr-Commit-Position: refs/heads/main@{#924593}
I've added the explainer to our MsEdgeExplainers repo: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/main/Accessibility/PrefersContrast/explainer.md |
Note: we are still waiting for the TAG review to complete (it's been assigned to someone so hopefully not long): w3ctag/design-reviews#663 Bug: 1107431 Change-Id: I6ca24866759fe2d2e602a01934f7ac186ad5cdb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3093026 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Sara Tang <sartang@microsoft.com> Cr-Commit-Position: refs/heads/main@{#924593} NOKEYCHECK=True GitOrigin-RevId: 0cfd656314ff9833684c443dd662c79cf706c45e
Ya ya yawm TAG!
I'm requesting a TAG review of the prefers-contrast media query.
This media feature from Media Queries Level 5 lets authors adapt web content to a user-selected contrast scheme. Keywords: 'more', 'less', 'custom', and 'no-preference'. This feature was previously discussed in #583 but the syntax has since changed.
Further details:
We'd prefer the TAG provide feedback as (please delete all but the desired option):
🐛 open issues in our GitHub repo for each point of feedback
The text was updated successfully, but these errors were encountered: