-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add non-"fully active" document question #128
Conversation
As discussed in w3ctag/design-reviews#628, there are some privacy considerations that might be worth pointing out in the Security & Privacy Questionnaire. This change adds a question on non-"fully active" document handling to the questionnaire.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks solid to me!
questionnaire.markdown
Outdated
@@ -37,4 +37,5 @@ For your convenience, a copy of the questionnaire's questions is quoted here in | |||
> Considerations" sections? | |||
> 17. Do features in your specification enable origins to downgrade default | |||
> security protections? | |||
> 18. What should this questionnaire have asked? | |||
> 18. How does your feature handle non-"[=Document/fully active=]" documents? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdown doesn't support Bikeshed linking syntax, so maybe use a Markdown link here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should make the Python script that generates this markdown file strip out Bikeshed syntax.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right, this was automatically generated. I've removed the bikeshed syntax here and index.bs as well to not be blocked by the script change!
index.bs
Outdated
How does your feature handle non-"fully active" documents? | ||
</h3> | ||
|
||
After a user navigated away from a document, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
navigates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
index.bs
Outdated
|
||
After a user navigated away from a document, | ||
the document might stay around in a non-"[=Document/fully active=]" state, | ||
and might be reused when the user navigates back to the entry holding the document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure "to the entry" is easy to understand. Maybe just remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed, thanks!
Nice! That's something we wanted to add. Thanks for doing it! + @msramek FYI |
Thanks a lot for the review! I've addressed the comment and so this should be mergeable now. I heard from @ArthurSonzogni that Chrome's intents review process now also considers a feature's relationship with BFCache/non-fully active documents, so it's nice to have an official linkable guide here :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely.
As discussed in w3ctag/design-reviews#628, there are some privacy considerations that might be worth pointing out in the Security & Privacy Questionnaire.
This change adds a question on non-"fully active" document handling to the questionnaire.
cc @hober @domenic @fergal
Note that there's another PR for the "Web Platform Design Principles" doc at w3ctag/design-principles#317
Preview | Diff