Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review FormData additions in XHR #87

Closed
inexorabletash opened this issue Oct 5, 2015 · 10 comments
Closed

Review FormData additions in XHR #87

inexorabletash opened this issue Oct 5, 2015 · 10 comments
Assignees

Comments

@inexorabletash
Copy link

The FormData interface grew some additional methods beyond the historical append, which allow the keys/values to be inspected, modified, and so forth:

https://xhr.spec.whatwg.org/#interface-formdata

These have shipped (apart from the iterator?) in Firefox. We have them implemented behind an experimental flag in Chrome and are looking for any feedback from the TAG before we ship.

@mikewest
Copy link

mikewest commented Oct 6, 2015

While you're looking at FormData in general, you might as well also peek at the "opaque" FormData additions in CREDENTIAL: https://w3c.github.io/webappsec-credential-management/#opaque-formdata :)

@mikewest
Copy link

mikewest commented Oct 6, 2015

(Which are also implemented behind an experimental flag in Chrome for that API)

@domenic
Copy link
Member

domenic commented Oct 6, 2015

I raised whatwg/xhr#27

@dbaron
Copy link
Member

dbaron commented Jan 14, 2016

It's almost orthogonal -- but I'd note there was a change from DOMString to USVString here, and whether it's in line with the guidance on which to use at http://heycam.github.io/webidl/#idl-USVString . It's possible the guidance (which also isn't particularly clear) needs updating and the change here was correct, but it seems like the sort of thing where we should have clear guidance on when APIs are supposed to use which. /cc @heycam

@mnot
Copy link
Member

mnot commented Jan 14, 2016

Discussed in Melbourne. Besides the issues discussed above (which we're still looking into), looks entirely reasonable. Should revisit in a call soon.

@plinss plinss added this to the tag-telcon-2016-02-03 milestone Jan 14, 2016
@annevk
Copy link
Member

annevk commented Jan 14, 2016

The reason it uses USVString is because when FormData is serialized, that's what you'll get. Seems bad to let the serialization format and object structure have different value spaces.

@plinss
Copy link
Member

plinss commented Jan 14, 2016

USVString use sounds fine, but one concern is interaction with other APIs that take DOMString, for example what happens when a FormData is constructed from a Form that contains elements with DOMString values set from script? What happens to any unpaired surrogates? The conversion from DOMString needs to be specified.

@domenic
Copy link
Member

domenic commented Jan 14, 2016

@plinss
Copy link
Member

plinss commented Jan 14, 2016

Ok, cool. Thanks.

@plinss
Copy link
Member

plinss commented Apr 13, 2016

Discussed 2016-04-13 telcon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants