Universaldot.me - Milestone 1

[stojanov-igor]

Milestone Delivery Checklist

• The milestone-delivery-template.md has been copied and updated.
• The invoice form 📝 has been filled out for this milestone.
• This pull request is being made by the same account as the accepted application.
• In case of acceptance, the payment will be transferred to the BTC/ETH payment address provided in the application.
• The delivery is according to the Guidelines for Milestone Deliverables.

Link to the application pull request: w3f/Grants-Program#714

[Noc2]

Thanks for the delivery. We will look into it as soon as possible. Btw. you are not allowed to submit your own evaluation for this. Or we would probably more or less ignore it. ;-)

[alxs]

@JosephKnecht-lab thanks for the delivery also from my side. In general, it looks really good. Nice work on the inline documentation, tests and explanatory videos. I only have the following comments:

• In your application, you committed to providing benchmark-based weight estimations for all extrinsics, but I think this is missing. Do you still want to implement those?
• The Dockerfile isn't working for me. Please double-check whether it works on your end.
• Could you create your own README for the node, instead of using the one from the template? Ideally, it would explain what the node does, how the pallets interact etc. as well as provide any instructions to run it with and w/o docker and test it.

[stojanov-igor]

Hi @alxs. Thank you for the feedback. I am glad someone likes the videos.

Regarding your points...

1. I have created benchmarks for all extrinsics as promised. The autogenerated weights for the extrinsics can be found here: UniversalDot/universal-dot-node@70e1884
2. I was able to build the image in Ubuntu. Docker seems to have some issues with the latest Mac M1 architecture. I pushed the image on DockerHub: https://hub.docker.com/r/universaldot/node .
3. I have updated the README.MD to reflect better the current state of the project. https://github.com/UniversalDot/universal-dot-node . There are some ongoing changes, but we will consolidate for the official release.

Let me know if you have any further questions/comments.

[alxs]

Sounds good, thank you. I wasn't able to build the node either with the latest stable or the latest nightly, what version of Rust are you using and could you try updating it? And could you provide instructions to run the node using Docker (also for the docker-compose repo if you want)? Mine simply exits.

[stojanov-igor]

Hi @alxs

To build the latest update from source, please checkout the add_weights branch. Here are the exact commands.
git clone https://github.com/UniversalDot/universal-dot-node.git
cd universal-dot-node
git checkout add_weights
cargo run --release -- --dev --tmp
(I am using rustc 1.58.1 (db9d1b20b 2022-01-20))
Alternatively, you can also connect to a node that is already running on VPS: "ws://109.235.70.27:9944"

I have updated the instructions for running the application with docker: https://github.com/UniversalDot/docker-compose. I tested it on ubuntu:20.04 machine and it builds correctly for me.

We are actively working on Milestone2, and would appreciate joining the substrate builder program. I had a call with Santiago Balaguer a while back and he mentioned that we will be automatically enrolled in the program after the first milestone is accepted. Is that still the correct process?

[alxs]

Thank you, that worked.

I meant instructions to run the node using Docker.

I'm getting nothing other than the error below when running the node+front end using docker compose. Any idea what the issue could be? By the way, I'd recommend renaming the repository since it's not docker-compose itself that it contains, but a different project. I.e. after cloning there's no way of knowing what the project is. Just a comment.

Let me get back to you on the Substrate Builders Program.

[stojanov-igor]

Hi @alxs

I can see how running docker-compose in docker-compose repo can be confusing. I have renamed the repo to compose-service. (https://github.com/UniversalDot/compose-service)

The error looks familiar. I have resolved it before can't recall the cause anymore. I have a front-end developer working on the React application at the moment, and the React application is to be delivered as part of milestone2.

We look forward to joining the Substrate Builders Program. Please let us know how we can do that... Thanks

[alxs]

True, I didn't realise the frontend wasn't part of M1. Just a few last things:

• Please modify these instructions (and potentially the Docker image) to describe how to run the node using Docker.
• Could you please merge everything that is part of the delivery into one branch in the universal-dot-node repo? Currently, it's split across 3 different branches.
• The Dockerfile in the add_pallets branch didn't work for me on Ubuntu either. Please make sure the final branch has a working one.
• Could you address the warnings reported by cargo clippy in pallet-dao and pallet-task?

Regarding the Substrate Builders Program, you aren't exactly automatically enrolled when your first milestone is accepted; you still need to apply. However, if you already applied Parity may just be waiting for this milestone to be accepted. If that's the case, please just reach out to Santiago once the milestone has been accepted or if you haven't applied yet, simply mention it in your application.

[stojanov-igor]

Hi @alxs

• I have modified the instructions for building the node. Use this Dockerfile as described in the instruction.
• I have merged all the code changes to a new branch callled master-release.
• The Dockerfile has been updated to use the master-release branch. I also made small adjustments to the locale and language settings which probably was causing problems.
• Great find. I have addressed all clippy warnings for the Task and Dao pallets.

I have already applied for the Substrate Builders Program. In fact, I have applied for the Substrate Builders Program before I applied for this grant. I will reach out again to Santiago or team after the milestone has been accepted. Thank you for your help.

[alxs]

Thanks for the changes. The docker script failed for me on two accounts - you need to first create the .local directory, and then with the following error:

error: failed to parse manifest at `/var/www/node-template/.cargo/registry/src/github.com-1ecc6299db9ec823/cranelift-entity-0.77.0/Cargo.toml`

Caused by:
  feature `resolver` is required

  this Cargo does not support nightly features, but if you
  switch to nightly channel you can add
  `cargo-features = ["resolver"]` to enable this feature
ERROR: 101

[stojanov-igor]

HI @alxs,

This is unusual since I just tested it and it worked for me on Ubuntu 20.04.

When I do a google search it seems to be an incompatibility with your cargo --version. You can see the open issue here: emilk/egui#297

[alxs]

How can this be? It's running on the same image for both of us. My cargo version shouldn't matter.

Could you test it on a fresh install?

[stojanov-igor]

I did a new build and it worked also. I have included the command-line output here: https://hackmd.io/@D3QwgNTnSnmMYhahCx8PMQ/ryxHg0Cjk5

If this is the only issue left from milestone 1, we can investigate and fix it in Milestone 2 which is also nearly done.

By the way, I will be out of the office until Wednesday of next week so there might be a delay in responses.

[alxs]

Are you actually running the script in the universal-dot-node repository? Given the prompt at the end, it doesn't look like it.

[stojanov-igor]

Are you actually running the script in the universal-dot-node repository? Given the prompt at the end, it doesn't look like it.

No. Sorry. I was using the Dockerfile from the compose-service. I have updated the application file to include the correct Dockerfile.

[alxs]

Thanks, that one worked. Please think of updating the instructions in the repository of the node too.

With this, I'm happy to tell you that the milestone is a pass! You can find my evaluation notes here. I'll notify the operations team to pay out your invoice.

[alxs]

@JosephKnecht-lab we have a bot that should have posted the following, but failed since the link in your delivery points to your fork:

Congratulations on completing the first milestone of this grant! As part of the Grants Program, we want to help grant recipients acknowledge their grants publicly. To that end, we’ve created a badge for projects that successfully deliver their first milestone. Note that it must only be used within the context of the delivered work, so please do not display it on your team or project's homepage unless accompanied by a short description of the grant.

Furthermore, you're now welcome to announce the grant publicly. Please remember to observe the foundation’s guidelines in doing so. In case you haven't done so yet, you may also reach out to grantsPR@web3.foundation for feedback on your announcement and cross-promotion.

Thank you for your contribution and good luck with the remaining milestones, if any! As usual, please let us know if you run into any delays by leaving a comment on the application PR, or directly submitting an amendment.

[stojanov-igor]

Great. Thank you @alxs.

I have already reached out to Santiago regarding joining the Substrate Builders Program.

We will update our GitHub repositories to include the badge and will make announce the grant publicly in due time.

Thanks again.

[RouvenP]

hi @JosephKnecht-lab we transferred the payment today. Thanks!