Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pacific store #110

Merged
merged 8 commits into from
Dec 10, 2020
Merged

Pacific store #110

merged 8 commits into from
Dec 10, 2020

Conversation

vlbos
Copy link
Contributor

@vlbos vlbos commented Nov 19, 2020

Grant Application Checklist

  • The application-template.md has been copied, renamed ( "project_name.md") and updated.
  • A BTC address for the payment of the milestones is provided inside the application.
  • The software of the project will be released under the Apache license version 2.0 as specified in the terms and conditions.
  • The total funding amount of the project is below CHF 30k at the time of submission.

@mmagician
Copy link
Contributor

@vlbos Thank you for the application.
We actually have some NFT teams building on Polkadot already, for example RareLink. Perhaps you could briefly comment on how your solution differs from theirs?

@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label Nov 20, 2020
@vlbos
Copy link
Contributor Author

vlbos commented Nov 21, 2020

@vlbos Thank you for the application.
We actually have some NFT teams building on Polkadot already, for example RareLink. Perhaps you could briefly comment on how your solution differs from theirs?

Thank you for your review .we update it . listing on how our solution differs from RareLink or Others

@mmagician mmagician self-requested a review November 23, 2020 14:27
Copy link
Contributor

@mmagician mmagician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vlbos I have a couple of questions:

  1. We've already built the largest marketplace for crypto collectibles

Could you provide a link to such marketplace? I never heard of PacificStore and also couldn't find any details online.

  1. Why do you have Technical specifications and Zenlink DEX Module design as part of your first milestone?

  2. We will need much more details in your milestones than Creation of integration APIs + documentation. This doesn't say anything about the code that you'll deliver. This applies to all of your milestones. Please update your grant application with relevant specifications please.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vlbos Please also specify the programming language/framework, which you are planning to use for each deliverable.

@vlbos
Copy link
Contributor Author

vlbos commented Nov 26, 2020

@vlbos I have a couple of questions:

  1. We've already built the largest marketplace for crypto collectibles

Could you provide a link to such marketplace? I never heard of PacificStore and also couldn't find any details online.

  1. Why do you have Technical specifications and Zenlink DEX Module design as part of your first milestone?
  2. We will need much more details in your milestones than Creation of integration APIs + documentation. This doesn't say anything about the code that you'll deliver. This applies to all of your milestones. Please update your grant application with relevant specifications please.

Thank you for your reviews.I'm sorry for rookie mistakes in the document.we updated it .Add details of the code of our milestones

@vlbos
Copy link
Contributor Author

vlbos commented Nov 26, 2020

@vlbos Please also specify the programming language/framework, which you are planning to use for each deliverable.

Thank you for your reviews.we added programming language and framework part.

@vlbos vlbos requested review from mmagician and Noc2 November 26, 2020 23:56
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Some of the formatting seems to be off. Additionally could you combine the Deliverables with the programming language/framework in one table? As Marcin pointed out, the deliverables are still a bit unclear to me: for example “Making Offers”, how will this work. Is it it implemented in the smart contract as well as the UI. And how does “Using ERC-20 tokens” work? Are you referring to tokens on ethereum, when you say erc-20 tokens? And do I understand it correctly, that you want to first create a solidity contract and then compile this with solang into a smart contract for edgware, correct? Did you already start to work on this smart contract? It sounds a little bit like you want to port OpenSea to edgeware with the help of solang. Is this correct?

@vlbos
Copy link
Contributor Author

vlbos commented Nov 28, 2020

Thanks for the update. Some of the formatting seems to be off. Additionally could you combine the Deliverables with the programming language/framework in one table? As Marcin pointed out, the deliverables are still a bit unclear to me: for example “Making Offers”, how will this work. Is it it implemented in the smart contract as well as the UI. And how does “Using ERC-20 tokens” work? Are you referring to tokens on ethereum, when you say erc-20 tokens? And do I understand it correctly, that you want to first create a solidity contract and then compile this with solang into a smart contract for edgware, correct? Did you already start to work on this smart contract? It sounds a little bit like you want to port OpenSea to edgeware with the help of solang. Is this correct?

Thanks for the comment. basically correct.we will merge the tables ,simplify description ,elaborate more details of code.

@vlbos vlbos requested a review from Noc2 November 29, 2020 12:57
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. But if I understand it correctly, you are not really implementing all these functions and deliverables yourself. You are simply using solang to compile existing evm contracts into the correct wasm format for our contract module. I don’t understand why your deliverables also mention ink!, since it seems you won’t use ink!. Solang only compiles smart contracts to wasm in a way that the contract module can understand it. In general we would only support the parts of the application that focus on software development (that doesn’t already exist) related to Polkadot, Kusama and Substrate. So, I suggest to only focus on the parts that you actually have to implement and that are unique to our ecosystem.

@vlbos
Copy link
Contributor Author

vlbos commented Dec 2, 2020

Thanks for the update. But if I understand it correctly, you are not really implementing all these functions and deliverables yourself. You are simply using solang to compile existing evm contracts into the correct wasm format for our contract module. I don’t understand why your deliverables also mention ink!, since it seems you won’t use ink!. Solang only compiles smart contracts to wasm in a way that the contract module can understand it. In general we would only support the parts of the application that focus on software development (that doesn’t already exist) related to Polkadot, Kusama and Substrate. So, I suggest to only focus on the parts that you actually have to implement and that are unique to our ecosystem.

Thanks for your suggestion. About wyvern contracts Rust cargo-contracts implement ,would you support it ?
These are the Ethereum smart contracts for the Wyvern Protocol, the Wyvern ERC20 token (WYV), and the Wyvern DAO.
it also is base part of opensea-js. as out first step to implement opensea-js on polkadot.
our future plan is the have-to implement of the other part of opensea-js on polkadot.it include opensea-js backend service and auto-generated UI according to a user's deployed contract and metadata.

By the way,
"you are not really implementing all these functions and deliverables yourself"
Our team has four people working part-time in this development.if needed ,we will add developers.

@Noc2
Copy link
Collaborator

Noc2 commented Dec 2, 2020

Thanks for the quick response. In this case, what are you developers working on? If you for example need to adapt the existing opensea-js to integrate polkadot.js as well as add unique substrate related features, this would be potentially worth a small grant from us. Other than that, I know that https://moonbeam.network/ wants to launch a grant program soon, which might be better suited for these kinds of projects.

@vlbos
Copy link
Contributor Author

vlbos commented Dec 2, 2020

Thanks for the quick response. In this case, what are you developers working on? If you for example need to adapt the existing opensea-js to integrate polkadot.js as well as add unique substrate related features, this would be potentially worth a small grant from us. Other than that, I know that https://moonbeam.network/ wants to launch a grant program soon, which might be better suited for these kinds of projects.

Thanks for your suggestion.our developers are working on frontend (javascript/typescript) or backend/system(C++/Rust) .
we will update the application according to your suggestions.
Many thanks

@vlbos vlbos requested a review from Noc2 December 7, 2020 12:56
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. This looks much better to me and I’m willing to go ahead with it.

@vlbos
Copy link
Contributor Author

vlbos commented Dec 7, 2020

Thanks for the update. This looks much better to me and I’m willing to go ahead with it.

Thanks for the comment and approval.

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Dec 8, 2020
@Noc2 Noc2 merged commit 91e1a42 into w3f:master Dec 10, 2020
@github-actions
Copy link
Contributor

Congratulations! As part of the Open Grants Program, we want to help winning teams acknowledge their grants publicly while observing the foundation’s guidelines. To that end, we’ve created a badge for grant-winning teams. Here is a link to the download and guidelines.

Once you complete your first grant milestone, would you be interested in collaborating on an announcement about the work you’re doing? If so, then please get in touch with us at grantspr@web3.foundation prior to making the announcement (at least two weeks notice is preferred) so that we can coordinate on timing and content.

Please don’t announce the grant publicly before you finished at least the first milestone of the project.

@vlbos
Copy link
Contributor Author

vlbos commented Dec 10, 2020

Thanks for the grant.

@alxs
Copy link
Contributor

alxs commented Aug 16, 2021

@vlbos care to share a quick status update, along with an ETA if possible? The project repo looks inactive and we were hoping to receive your next delivery a bit over 2 months ago now.

As long as you're actively working on the project, delays aren't a big problem, but we'd appreciate it if you could keep us in the loop. Note that if we don't hear from you soon, we will assume you're no longer interested and terminate the agreement.

@alxs
Copy link
Contributor

alxs commented Aug 30, 2021

This grant is being terminated due to inactivity. Feel free to apply again if you're still interested.

@alxs alxs mentioned this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants