Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add polkadot snap grant application #1166

Merged
merged 5 commits into from Oct 12, 2022
Merged

add polkadot snap grant application #1166

merged 5 commits into from Oct 12, 2022

Conversation

aaronisme
Copy link
Contributor

Project Abstract

“Polkadot Snap” will help the Dapp applications open up one of the biggest WEB3.O entrances - MetaMask, where users could continue exploring the Polkadot ecosystem with their familiar MetaMask Wallet.

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • A BTC, Ethereum (USDT/USDC/DAI) or Polkadot/Kusama (aUSD) address for the payment of the milestones is provided inside the application.
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

@CLAassistant
Copy link

CLAassistant commented Sep 7, 2022

CLA assistant check
All committers have signed the CLA.

@Noc2 Noc2 self-assigned this Sep 7, 2022
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the application. In general, this sounds really interesting, but I have a few comments:

  • Level 2 grants are only up to 30k. Would you be willing to reduce the price accordingly?
  • Deliverables 0a-0d of the template are usually mandatory for all milestones, and deliverable 0e at least for the last one.
  • Could you reintegrate the table of the template for the milestones and structure it accordingly?

@Noc2 Noc2 added the changes requested The team needs to clarify a few things first. label Sep 7, 2022
@aaronisme
Copy link
Contributor Author

@Noc2 Hi David, I have updated the application as you requested

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Could you also integrate the list of the estimated duration,
FTE and Costs for each milestone? See template. Just to make sure we don’t forget anything. And usually, the deliveries with a zero are the default deliveries and numbers 1, etc are the actual technical deliveries of your project. Feel free to integrate things like: “Building the snap application Provider and js sdk which wrap the snap application which provide injected object for the Dapp developer. Writing the documentation for the Dapp developer.” into the deliverable table.

@Noc2 Noc2 assigned takahser and unassigned Noc2 Sep 9, 2022
Copy link
Collaborator

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronisme thanks for submitting your grant application.
As David already mentioned, there are some details missing in your deliveries. Could you update them? Let me know if you have any questions.

@aaronisme
Copy link
Contributor Author

@Noc2 @takahser I have updated the application for all the comments. Please check it.

Noc2
Noc2 previously approved these changes Sep 26, 2022
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Given the background of your team and your previous deliveries, I’m happy to already go ahead with it. But it still would be nice if you could add more technical details to the milestones and specifically the tables of the milestones. For example, what does “ Staking etc.” mean? Could you be more specific?

@aaronisme
Copy link
Contributor Author

@Noc2 Thanks for the feedback. @juntao Do you think this application is ready to go?

@juntao
Copy link
Contributor

juntao commented Sep 28, 2022

@aaronisme I do not think you meant to tag me in your comment? 😅

@Noc2
Copy link
Collaborator

Noc2 commented Sep 29, 2022

@aaronisme it would still be nice if you could fix my comments. Afterward, I will ping the rest of the committee again.

Copy link
Collaborator

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to add the mandatory deliverables, where applicable:

Deliverables 0a-0d are mandatory for all milestones, and deliverable 0e at least for the last one.

Other than that, I'd be happy to approve it.

applications/PolkadotSnap.md Outdated Show resolved Hide resolved
applications/PolkadotSnap.md Outdated Show resolved Hide resolved
@Noc2
Copy link
Collaborator

Noc2 commented Oct 6, 2022

@aaronisme Btw. let us know if you have any questions. We are still highly interested in this project.

@aaronisme
Copy link
Contributor Author

@Noc2 @takahser I have updated the application to fix all the comments. Free to let me know if you have any questions. And btw we have already started the work of the milestone one :)

Noc2
Noc2 previously approved these changes Oct 10, 2022
Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. I'm happy to go ahead with it and share it with the rest of the team.

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. and removed changes requested The team needs to clarify a few things first. labels Oct 10, 2022
takahser
takahser previously approved these changes Oct 10, 2022
Copy link
Collaborator

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aaronisme thanks for the update, happy to go ahead with it as well.

@semuelle semuelle changed the title add polkdadot snap grant application add polkadot snap grant application Oct 10, 2022
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the application. I am generally happy to support this. Just two small requests:

applications/PolkadotSnap.md Outdated Show resolved Hide resolved
applications/PolkadotSnap.md Show resolved Hide resolved
@aaronisme aaronisme dismissed stale reviews from takahser and Noc2 via 6afcf4b October 12, 2022 01:19
@aaronisme
Copy link
Contributor Author

@semuelle I have updated the application for your comments and for questions. Free to ping me if any questions.

Copy link
Collaborator

@takahser takahser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving this.

Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@semuelle semuelle merged commit 850999f into w3f:master Oct 12, 2022
@github-actions
Copy link
Contributor

Congratulations and welcome to the Web3 Foundation Grants Program! Please refer to our Milestone Delivery repository for instructions on how to submit milestones and invoices, our FAQ for frequently asked questions and the support section of our README for more ways to find answers to your questions.

Before you start, take a moment to read through our announcement guidelines for all communications related to the grant or make them known to the right person in your organisation. In particular, please don't announce the grant publicly before at least the first milestone of your project has been approved. At that point or shortly before, you can get in touch with us at grantsPR@web3.foundation and we'll be happy to collaborate on an announcement about the work you’re doing.

Lastly, please remember to let us know in case you run into any delays or deviate from the deliverables in your application. You can either leave a comment here or directly request to amend your application via PR. We wish you luck with your project! 🚀

@keeganquigley
Copy link
Contributor

Hi @aaronisme just curious if you have any updates on the milestone progress? Thanks!

@keeganquigley
Copy link
Contributor

Hi @aaronisme friendly reminder, are you still working on this grant?

@aaronisme
Copy link
Contributor Author

Yes, we are building the snap for the Milestone 1 currently

@keeganquigley
Copy link
Contributor

Thanks @aaronisme if you think it will be significantly delayed, please consider filing an amendment to extend the timeline. Since milestone 2 will likely be delayed as well. Thanks!

@keeganquigley
Copy link
Contributor

Hi @aaronisme are you able to give us an update on M1?

@keeganquigley
Copy link
Contributor

pinging @aaronisme for a reminder.

@Noc2
Copy link
Collaborator

Noc2 commented May 28, 2023

@aaronisme, any update here, if we don't hear anything from you within the next week, we will probably terminate the grant and try to find another team for the metamask snap integration.

@aaronisme
Copy link
Contributor Author

aaronisme commented May 30, 2023

@Noc2 @keeganquigley

Sorry for the late response. Currently our engineering team are absorb in the firmware development of our next gen hardware wallet. We are planning to move this snap into Q4 this year. Hope we can start on Oct.

Sorry for the inconvenience.

@Noc2
Copy link
Collaborator

Noc2 commented May 30, 2023

Thanks for the update @aaronisme. In this case, we will cancel the grant for now, and you can potentially reapply at the end of the year.

@Noc2 Noc2 mentioned this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants