-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amend ink! analyzer (phase 2) #1951
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read and hereby sign the Contributor License Agreement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update. Sounds good to me. I will share it with the rest of the team.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Amend ink! analyzer (phase 2) * minor updates for ink! analyzer (phase 2) amendment
* Amend ink! analyzer (phase 2) * minor updates for ink! analyzer (phase 2) amendment
Project Abstract
This is an amendment to the ink! Analyzer (phase 2) grant.
Context:
While working on semantic analyzer updates, I noticed that I missed the chain extension associated
ErrorCode
type in the scoping, which (together with theimpl Environment
type used byenv
andenvironment
ink! attribute arguments) is one the "special" types for ink!. So I'm updating the scope to include semantic analysis related to theErrorCode
type.Updates:
ErrorCode
type related diagnostics and quickfixes.ErrorCode
type milestone and a relatively small bump in cost compared to the original combined language server milestone (previously milestone 4).References:
https://use.ink/macros-attributes/chain-extension#error-code
https://use.ink/macros-attributes/chain-extension#technical-limitations
Grant level
Application Checklist
project_name.md
).@_______:matrix.org
(change the homeserver if you use a different one)