Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend ink! analyzer (phase 2) #1951

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Conversation

davidsemakula
Copy link
Contributor

@davidsemakula davidsemakula commented Sep 5, 2023

Project Abstract

This is an amendment to the ink! Analyzer (phase 2) grant.

Context:
While working on semantic analyzer updates, I noticed that I missed the chain extension associated ErrorCode type in the scoping, which (together with the impl Environment type used by env and environment ink! attribute arguments) is one the "special" types for ink!. So I'm updating the scope to include semantic analysis related to the ErrorCode type.

Updates:

  • I've added a new milestone for the semantic analyzer (now milestone 4) for the chain extension associated ErrorCode type related diagnostics and quickfixes.
  • I've split the language server milestone (previously milestone 4), into 2 new milestones (now milestone 5 and 6), with the second language server milestone (now milestone 6) including updates for the new ErrorCode type milestone and a relatively small bump in cost compared to the original combined language server milestone (previously milestone 4).

References:
https://use.ink/macros-attributes/chain-extension#error-code
https://use.ink/macros-attributes/chain-extension#technical-limitations

Grant level

  • Level 1: Up to $10,000, 2 approvals
  • Level 2: Up to $30,000, 3 approvals
  • Level 3: Unlimited, 5 approvals (for >$100k: Web3 Foundation Council approval)

Application Checklist

  • The application template has been copied and aptly renamed (project_name.md).
  • I have read the application guidelines.
  • Payment details have been provided (bank details via email or BTC, Ethereum (USDC/DAI) or Polkadot/Kusama (USDT) address in the application).
  • The software delivered for this grant will be released under an open-source license specified in the application.
  • The initial PR contains only one commit (squash and force-push if needed).
  • The grant will only be announced once the first milestone has been accepted (see the announcement guidelines).
  • I prefer the discussion of this application to take place in a private Element/Matrix channel. My username is: @_______:matrix.org (change the homeserver if you use a different one)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@davidsemakula
Copy link
Contributor Author

I have read and hereby sign the Contributor License Agreement.

Copy link
Collaborator

@Noc2 Noc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. Sounds good to me. I will share it with the rest of the team.

@Noc2 Noc2 added ready for review The project is ready to be reviewed by the committee members. amendment This PR proposes changes to an existing application. labels Sep 6, 2023
Copy link
Member

@semuelle semuelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@semuelle semuelle requested a review from nikw3f September 6, 2023 11:59
@takahser takahser merged commit af1a150 into w3f:master Sep 6, 2023
11 checks passed
@davidsemakula davidsemakula deleted the ink-analyzer branch September 6, 2023 13:59
@davidsemakula davidsemakula mentioned this pull request Sep 28, 2023
10 tasks
ainhoa-a pushed a commit to ainhoa-a/Grants-Program that referenced this pull request Jan 26, 2024
* Amend ink! analyzer (phase 2)

* minor updates for ink! analyzer (phase 2) amendment
taqtiqa-mark pushed a commit to taqtiqa-mark/Grants-Program that referenced this pull request Jun 6, 2024
* Amend ink! analyzer (phase 2)

* minor updates for ink! analyzer (phase 2) amendment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amendment This PR proposes changes to an existing application. ready for review The project is ready to be reviewed by the committee members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants