Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated dependencies, including TypeORM 0.3.10 #235

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

erlendfh
Copy link

No description provided.

@erlendfh erlendfh force-pushed the update-dependencies branch 2 times, most recently from 024d3fd to 29e50c2 Compare October 13, 2022 12:09
Copy link

@MykleNero MykleNero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the review/approval process is on this project as I am just a humble user. However, the changes here look solid. How do we get some eyes on this?

@@ -52,14 +51,15 @@ export class EntityFactory<Entity, Context> {
throw new Error(message)
}
} else {
console.warn('No db connection is given: ', dataSource.isInitialized, dataSource)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should printWarning be used here instead?

@@ -1,7 +1,7 @@
{
"compilerOptions": {
"lib": ["es5", "es6"],
"target": "es5",
"lib": ["dom", "es5", "es6"],

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the "dom" lib needed? Just asking out of curiousity.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MykleNero thanks for taking the time to look at this! The "dom" was just a quick fix for this error:

$ yarn build
yarn run v1.22.17
$ rimraf dist
$ tsc --project ./tsconfig.build.json
node_modules/@types/node/ts4.8/stream.d.ts:842:39 - error TS2304: Cannot find name 'Blob'.

842             static from(src: Stream | Blob | ArrayBuffer | string | Iterable<any> | AsyncIterable<any> | AsyncGeneratorFunction | Promise<any> | Object): Duplex;
                                          ~~~~
Found 1 error in node_modules/@types/node/ts4.8/stream.d.ts:842

Blob is defined as a global in the browser, but is a member of buffer in node. It's a little unclear to me what is dependent on stream, so adding "dom" to lib is the only workaround I've found so far.

@tbakerx
Copy link

tbakerx commented Nov 24, 2022

I'm not sure what the review/approval process is on this project as I am just a humble user. However, the changes here look solid. How do we get some eyes on this?

Agreed, would be great to get this in.

@stemount
Copy link

@w3tecch @erlendfh Would be good to get this ready for typeorm v3.0.12 and finally get this merged in!!?

This PR has been open for too long, does the project have co-maintainers as this package is critically missing functionality!

❤️

@BatuhanW
Copy link

Hello @erlendfh PR looks great and it seems this repo is not maintained anymore. Could you publish your version to NPM with a different name? I'd do it but since it's your work, better if you do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants