Extend/Refactor plugin.js & Add More Settings #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed a quick URL mitigator. This is needed to use new `saveKeyIgnoreParams` config. I dont know who the original author is, but we can update when found.
The way autosave was constructing `SaveKey` wasnt very dynamic, and was too specific to be useful on pages with URLs that contain un-needed querystrings (params). This commit introduces more flexibility as well as an option to make autosave url (for SaveKey name) more flexible. In addition there are new configs available to allow an OP to adjust things such as input target identifier right from config.js (without requiring a plugin shim init for editor object). New settings available are: - `saveKeyPrefix: 'localstore_prefix',` <-- Optional `SaveKey` prefix, defaults to "autosave" for backwards compatibility - `saveKeyIgnoreParams: ['querystring_to_ignore', 'something_else', 'gclid'],` <-- Querystrings to scrub out of `SaveKey` URL - `saveKeyIgnoreProtocol: true,` <-- Whether or not to include the https:// in `SaveKey` name, defaults to false for backwards compatibility - `saveKeyDelimiter: ' | ',` <-- Optional `SaveKey` URL delimiter, defaults to "_" for backwards compatibility - `saveKeyAttribute: 'id'` <-- The unique attribute to target for `SaveKey` name, defaults to element "name" for backwards compatibility The `SaveKey` is then constructed using those settings and pushed to config.
I may have missed something here, but loadPlugin() is constructing its own config defaults for no good reason. It pulls from 2nd arg what is constructed on init, so we can eliminate all the if checks.
dhaupin
changed the title
dhaupin
added a commit
to dhaupin/cs-cart-lib_ckeditor_full
that referenced
this pull request
Jul 5, 2017
Awaiting this pull request: w8tcha/CKEditor-AutoSave-Plugin#87
dhaupin
added a commit
to dhaupin/cs-cart-lib_ckeditor_full
that referenced
this pull request
Jul 5, 2017
References changes from w8tcha/CKEditor-AutoSave-Plugin#87
|
thanks |
dhaupin
added a commit
to dhaupin/CKEditor-AutoSave-Plugin
that referenced
this pull request
Jul 21, 2017
Merge pull request w8tcha#87 from dhaupin/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps AutoSave become more flexible to config, more accurate when it saves, and less bossy when loading. Solves #86