Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asyncio parse fixes #2

Merged

Conversation

kmike
Copy link

@kmike kmike commented Jul 27, 2022

  • merged master
  • fixed typing errors

Gallaecio and others added 30 commits March 2, 2022 17:30
engine: prevent slot method call after unsetting the slot
CrawlerProcess: initialize the reactor only once
…ialization

2.6 release notes request serialization
* Enforce matching proxy request meta and Proxy-Authorization header

* Cover proxy credential security fix in the release notes

* Remove extra empty line

* Reword the security issue description

* Address scenario where Proxy-Authorization is unexpectedly removed by a prior middleware

* Set the release date of Scrapy 2.6.2 and 1.8.3
@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2022

Codecov Report

Merging #2 (56e2eea) into asyncio-parse-asyncgen-proper-rebased (b21c160) will increase coverage by 0.01%.
The diff coverage is 94.87%.

@@                            Coverage Diff                            @@
##           asyncio-parse-asyncgen-proper-rebased       #2      +/-   ##
=========================================================================
+ Coverage                                  88.82%   88.83%   +0.01%     
=========================================================================
  Files                                        162      162              
  Lines                                      10950    10963      +13     
  Branches                                    1889     1896       +7     
=========================================================================
+ Hits                                        9726     9739      +13     
+ Misses                                       946      943       -3     
- Partials                                     278      281       +3     
Impacted Files Coverage Δ
scrapy/commands/parse.py 27.93% <ø> (+1.11%) ⬆️
scrapy/downloadermiddlewares/httpproxy.py 96.49% <91.30%> (-3.51%) ⬇️
scrapy/cmdline.py 67.96% <100.00%> (+1.30%) ⬆️
scrapy/core/engine.py 83.95% <100.00%> (-0.26%) ⬇️
scrapy/crawler.py 87.76% <100.00%> (+0.13%) ⬆️
scrapy/utils/reactor.py 76.92% <100.00%> (ø)
scrapy/extensions/memusage.py 50.00% <0.00%> (-1.12%) ⬇️
scrapy/commands/edit.py 51.85% <0.00%> (+7.40%) ⬆️

@wRAR wRAR merged commit faa12d1 into wRAR:asyncio-parse-asyncgen-proper-rebased Jul 27, 2022
@wRAR wRAR deleted the asyncio-parse-fixes branch July 27, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants