forked from scrapy/scrapy
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asyncio parse fixes #2
Merged
wRAR
merged 30 commits into
wRAR:asyncio-parse-asyncgen-proper-rebased
from
scrapy:asyncio-parse-fixes
Jul 27, 2022
Merged
Asyncio parse fixes #2
wRAR
merged 30 commits into
wRAR:asyncio-parse-asyncgen-proper-rebased
from
scrapy:asyncio-parse-fixes
Jul 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmike
commented
Jul 27, 2022
- merged master
- fixed typing errors
engine: prevent slot method call after unsetting the slot
CrawlerProcess: initialize the reactor only once
…ialization 2.6 release notes request serialization
Fix TypeError in parse command
* Enforce matching proxy request meta and Proxy-Authorization header * Cover proxy credential security fix in the release notes * Remove extra empty line * Reword the security issue description * Address scenario where Proxy-Authorization is unexpectedly removed by a prior middleware * Set the release date of Scrapy 2.6.2 and 1.8.3
Merge 2.6 into the main branch
Codecov Report
@@ Coverage Diff @@
## asyncio-parse-asyncgen-proper-rebased #2 +/- ##
=========================================================================
+ Coverage 88.82% 88.83% +0.01%
=========================================================================
Files 162 162
Lines 10950 10963 +13
Branches 1889 1896 +7
=========================================================================
+ Hits 9726 9739 +13
+ Misses 946 943 -3
- Partials 278 281 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.