[R66] the file watcher regex are tested only against a full path #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, the regex filtering in the filewatcher was only able to match filenames.
In recursive mode, it was impossible to math a subpath.
During the 3.1 development cycle, I pushed some changes to match full paths. However, this had the side-effect to only allow file matching if the regex started with
.*
to match the subpath (ex:.*.csv
). I.e. the regexmyfile\.txt
whould not matchsubpath/myfile.txt
.This PR allows both regex to work as expected:
myfile\.txt
matchesmyfile.txt
as well assubpath/myfile.txt
subdir/.+\.txt
matchessubdir/myfile.txt