Fix IE8 issues with string.trim and such

wachunga · Oct 22, 2012 · 9e282e1 · 9e282e1
1 parent 0309f05
commit 9e282e1
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 10 deletions.
diff --git a/public/js/IssueManager.js b/public/js/IssueManager.js
@@ -138,7 +138,7 @@ define([
 	};
 
 	function getFilterInputValue() {
-		return $("#issueFilter").val().trim();
+		return $.trim($("#issueFilter").val());
 	}
 
 	IssueManager.prototype.resetFilters = function () {

diff --git a/public/js/ProjectView.js b/public/js/ProjectView.js
@@ -71,7 +71,7 @@ function ($, _, ko, timeago, tooltips, util, Issue, Notifier, UserManager, Messa
 	};
 
 	function isCommand(input) {
-		return input.trim().charAt(0) === "/";
+		return $.trim(input).charAt(0) === "/";
 	}
 
 	function ArgError(message) {
@@ -143,8 +143,8 @@ function ($, _, ko, timeago, tooltips, util, Issue, Notifier, UserManager, Messa
 
 		try {
 			var matches = input.match(/[:\/]([\S]+)(?:\s+(.*))?/);
-			var cmd = matches[1] && matches[1].trim();
-			var rest = matches[2] && matches[2].trim();
+			var cmd = matches[1] && $.trim(matches[1]);
+			var rest = matches[2] && $.trim(matches[2]);
 
 			var id;
 			switch (cmd.toLowerCase()) {

diff --git a/public/js/TagFilter.js b/public/js/TagFilter.js
@@ -2,13 +2,13 @@ define(['underscore', 'ko'], function (_, ko) {
 
 	var TagState = {
 		off: -1,
-		default: 0,
+		'default': 0,
 		on: 1
 	};
 
 	function TagFilter(label) {
 		this.label = label;
-		this.state = ko.observable(TagState.default);
+		this.state = ko.observable(TagState['default']);
 	}
 
 	TagFilter.prototype.getSymbol = function () {
@@ -23,7 +23,7 @@ define(['underscore', 'ko'], function (_, ko) {
 	};
 
 	TagFilter.prototype.isActive = function () {
-		return this.state() !== TagState.default;
+		return this.state() !== TagState['default'];
 	};
 
 	TagFilter.prototype.toggle = function () {
@@ -41,7 +41,7 @@ define(['underscore', 'ko'], function (_, ko) {
 
 	TagFilter.resetAll = function (tagFilters) {
 		_.each(tagFilters, function (tagFilter) {
-			tagFilter.state(TagState.default);
+			tagFilter.state(TagState['default']);
 		});
 	};
 

diff --git a/public/js/UserManager.js b/public/js/UserManager.js
@@ -36,7 +36,7 @@ define(['jquery', 'ko', 'underscore', 'util'], function ($, ko, _, util) {
 	UserManager.prototype.attemptLogin = function () {
 		this.invalidName(false);
 		var name = this.$nameInput.val();
-		if (!name || name.trim().length < 3) { // TODO: disallow other chars?
+		if (!name || $.trim(name).length < 3) { // TODO: disallow other chars?
 			this.invalidName(true);
 			return;
 		}

diff --git a/public/js/main.js b/public/js/main.js
@@ -19,7 +19,7 @@ require(['jquery', 'ko'], function ($, ko) {
 		var viewModel = {
 			error: ko.observable(),
 			submitForm: function (form) {
-				var name = $('#projectNameInput').val().trim();
+				var name = $.trim($('#projectNameInput').val());
 				if (!name || name.length < 3) {
 					this.error('Why so terse? You can do better.');
 					return false;