Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-use estimated longitudinal axis for hip data by part2 in part3 #1024

Closed
vincentvanhees opened this issue Jan 29, 2024 · 1 comment · Fixed by #1025
Closed

Re-use estimated longitudinal axis for hip data by part2 in part3 #1024

vincentvanhees opened this issue Jan 29, 2024 · 1 comment · Fixed by #1025
Assignees
@vincentvanhees
Labels
sleep (GGIRpart3+4)

Comments

@vincentvanhees
Copy link
Member

In part 3 we make a new estimate of longitudinal axis when wear location is hip, which is not consistent with part 2.
The approach in part 2 has been best evaluated, so it seems best to re-use that classification in part 3.

The classification from part 2 is stored in output value SUM$summary$if_hip_long_axis_id.
@vincentvanhees vincentvanhees self-assigned this Jan 29, 2024
@vincentvanhees
Copy link
Member Author

Additionally, if sensor.location == "hip" then store the longitudinal axis instead of anglez in part5 time series.

vincentvanhees added a commit that referenced this issue Jan 29, 2024
@vincentvanhees
tidy up use of assigned or estimated longitudinal axis for hip data
edac719 
- When working with hip data only estimate longitudinal axis once (in part 2) and then consistently use it in following parts
- Store angle in part 5 time series where the longitudinal axis will be assigned as default angle while other angles (if available) will be stored with their axis letter attached to it #1024
vincentvanhees added a commit that referenced this issue Jan 29, 2024
@vincentvanhees
pass on all angle columns to object ts #1024
b33abd8
vincentvanhees added a commit that referenced this issue Jan 29, 2024
@vincentvanhees
ensure correct axis is passed on #1024
f33c113 
- ensure correct axis is passed on to HASPT when sensorlocation = hip for daysleepers
- correct axis is stored in time series #1024
vincentvanhees added a commit that referenced this issue Jan 29, 2024
@vincentvanhees
only run longitudinal_axis extraction if sensor location is hip #1024
e19fd46
@vincentvanhees vincentvanhees mentioned this issue Jan 29, 2024
Merged
5 tasks
vincentvanhees added a commit that referenced this issue Jan 29, 2024
@vincentvanhees
tidy up documentation and changelog in relation to #1024
ee48cdd
vincentvanhees added a commit that referenced this issue Jan 30, 2024
@vincentvanhees
expand test coverage for #1024
8ba26cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincentvanhees vincentvanhees

Labels
sleep (GGIRpart3+4)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tidy up longitudinal axis detection and re-use when sensor is worn on the hip wadpac/GGIR
1 participant
@vincentvanhees