Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal axis QC plot not clear #983

Closed
vincentvanhees opened this issue Nov 27, 2023 · 7 comments · Fixed by #985
Closed

Horizontal axis QC plot not clear #983

vincentvanhees opened this issue Nov 27, 2023 · 7 comments · Fixed by #985

Comments

@vincentvanhees
Copy link
Member

@jhmigueles, I just created a QC plot and see:

image

which seems to be the result of the changes you made a few months ago in this commit: e79190f

Is this expected behaviour? It is hard now to see how many days there are and also it is unclear why time (12) does not increase.

Could it be that the horizontal axis label is incorrect and should read "time in each day" as opposed to time in the recording ? But even then I do not think the image is informative this way. I think it would be better to have both day numbers to quickly see what day it is and to replace 12 by the word noon or by midnight because 12am and 12pm are both 12.

@jhmigueles
Copy link
Collaborator

Yes, this is expected but clearly not ideal. I did not try this in a file with many days as you have here (it looked better in a 7-day recording. The ticks without labelling should state "0", but they are not there for limited horizontal space. Would it be ok if I set 2 x axes? One with time in the day (noon/midnight as you suggest), and another one below with the day counting?

@vincentvanhees
Copy link
Member Author

Yes, sounds good. And then maybe use a slightly smaller font size or reduce the font size if there are more than 10 days of data?

@jhmigueles
Copy link
Collaborator

@vincentvanhees Does this look better? Let me know if you have any extra feedback:

image

@vincentvanhees
Copy link
Member Author

looks good. I am wondering whether it can be more compact and still be clear. How about: "12:00" and "24:00" OR "12:00" and "00:00" OR "12h" and "24h"?

@vincentvanhees
Copy link
Member Author

vincentvanhees commented Nov 29, 2023

I mean, previously just 12 was not clear, but maybe now the days are indicated less information is enough.
It may even be sufficient to only indicate noon, because by the edges of the day it should be clear what midnight is?

@vincentvanhees
Copy link
Member Author

Actually. The labels for noon and midnight may not even be needed anymore, because day indicates start and end of the day and the ticks and noon and midnight are therefore automatically clear as such. So what you have is good but just remove the words noon and midnight. Agree?

@jhmigueles
Copy link
Collaborator

Better? I am doing a PR now so that you can test this in your data and give extra feedback if needed:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants