Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue983 xaxis q cplot #985

Merged
merged 20 commits into from
Dec 13, 2023
Merged

Issue983 xaxis q cplot #985

merged 20 commits into from
Dec 13, 2023

Conversation

jhmigueles
Copy link
Collaborator

@jhmigueles jhmigueles commented Dec 1, 2023

Closes #983 => Horizontal axis of QC plot is now redefined to make cleares the days length and also marking midnights and noons.

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Updated or expanded the documentation.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION file, if you think you made a significant contribution.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ededec3) 78.41% compared to head (5777400) 78.44%.
Report is 12 commits behind head on master.

❗ Current head 5777400 differs from pull request most recent head 8970c07. Consider uploading reports for the commit 8970c07 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #985      +/-   ##
==========================================
+ Coverage   78.41%   78.44%   +0.02%     
==========================================
  Files          99       99              
  Lines       13371    13386      +15     
==========================================
+ Hits        10485    10500      +15     
  Misses       2886     2886              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentvanhees vincentvanhees merged commit 968ed21 into master Dec 13, 2023
7 checks passed
@vincentvanhees vincentvanhees deleted the issue983_xaxisQCplot branch December 13, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Horizontal axis QC plot not clear
3 participants