Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes to sleeplog handling #1190

Merged
merged 6 commits into from
Aug 26, 2024
Merged

fixes to sleeplog handling #1190

merged 6 commits into from
Aug 26, 2024

Conversation

vincentvanhees
Copy link
Member

@vincentvanhees vincentvanhees commented Aug 23, 2024

Improved handling of sleeplog with empty column names, fixes #1138
Fixes bug for the combination advanced sleeplog and recordings that start exactly at midnight, where nights where not correctly matched, fixes #1188

Checklist before merging:

  • Existing tests still work (check by running the test suite, e.g. from RStudio).
  • Added tests (if you added functionality) or fixed existing test (if you fixed a bug).
  • Clean code has been attempted, e.g. intuitive object names and no code redundancy.
  • Documentation updated:
    • Function documentation
    • Chapter vignettes for GitHub IO
    • Vignettes for CRAN
  • Corresponding issue tagged in PR message. If no issue exist, please create an issue and tag it.
  • Updated release notes in inst/NEWS.Rd with a user-readable summary. Please, include references to relevant issues or PR discussions.
  • Added your name to the contributors lists in the DESCRIPTION file, if you think you made a significant contribution.
  • GGIR parameters were added/removed. If yes, please also complete checklist below.

@vincentvanhees vincentvanhees changed the title rebuild branch for PR 1189 to investigate why it fails fixes to sleeplog handling Aug 23, 2024
@vincentvanhees vincentvanhees marked this pull request as ready for review August 23, 2024 08:30
@vincentvanhees
Copy link
Member Author

Merging now, because this has been confirmed to work by two users who contacted me about the issues.

@vincentvanhees vincentvanhees merged commit 441c3e6 into master Aug 26, 2024
7 checks passed
@vincentvanhees vincentvanhees deleted the issue_1138_1188_rebuild branch August 26, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant