-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revision transition probability calculations and clean up function g.fragmentation #902
Conversation
…ng for TP in g.fragmentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm that this works in combination with segment analysis in part 5. NA values in fragmentation metrics are now handled and values are virtually the same. I noticed that for some days/segments, in the new version we get one less fragment than in the current version in master, which I think is in line with this revision of the function.
In this PR:
Relates to #817
@jhmigueles - When you have time in the upcoming weeks, would you mind testing that this branch still works correctly for the new part5 segment analysis as discussed here?
Checklist before merging:
inst/NEWS.Rd
with a user-readable summary. Please, include references to relevant issues or PR discussions.DESCRIPTION
andCITATION.cff
files.