-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OCI format, GZIP files can be smaller than 1024 bytes #511
base: main
Are you sure you want to change the base?
Conversation
Tested locally on my linux-amd64 with command: |
@wagoodman can you merge this? I'm unable to use dive lately due to this bug |
// Not a gzipped entry | ||
unwrappedReader = io.MultiReader(bytes.NewReader(buffer[:n]), tarReader) | ||
} | ||
// Try reading a GZIP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fwiw, the comment above (line 97) about Docker not gzipping very small layers might have to be removed (unfortunately, GitHub doesn't let me put that comment on that line 🤷)
@wagoodman I'm also not able to use dive because of this bug, and I'm running a compiled version of @Maddog2050's Is there anything blocking the PR? It would be great if you / we could get it sorted and pushed. Thanks! |
Does anyone know if there is an easy way to ask homebrew to install @Maddog2050 's fork? |
Hmmm
Well that was a deep rabbit hole. |
Not that I know of... I "just" did: git clone https://github.com/Maddog2050/dive.git
git co fix-oci-format
make bootstrap
make build Then, I Hopefully this fix will get merged soon and we can just use the official binary! :) |
Fix works for me too :) I hope this gets merged soon! 🤞 |
Here is a simple fix for the OCI format. When debugging I found that the GZIP size can be less than 1024 bytes when using containerd to pull the image.
I have tested with and without the "Use containerd for pulling and storing images" option in docker desktop and it appears to have fixed the issue. I also noticed issue #507 and downloading the example file it appears to resolve this issue also.
Fixes: #510 #507