Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Wagtail 5.2 compatibility #735

Merged
merged 8 commits into from
Nov 7, 2023
Merged

Add Wagtail 5.2 compatibility #735

merged 8 commits into from
Nov 7, 2023

Conversation

zerolab
Copy link
Collaborator

@zerolab zerolab commented Nov 6, 2023

This PR fixes #734, supersedes #733 and adds compatibility with Wagtail 5.2. It:

  • drops the unused LocalizedPreviewSidePanel
  • moves side panel definitions in edit_translation
  • adds the side panel for snippets (Wagtail 5.1+ only)
  • Fixes deprecation warnings around permissions
  • Moves the "Source > Translation(s)" breadcrumb bar out of React and into the template (a minor step towards Drop React #715)

Preliminary build:
wagtail_localize-1.7b1.tar.gz
wagtail_localize-1.7b2.tar.gz

To-Do:

  • use conditional templates for pre 5.1, and 5.1+ because of {% dropdown %}

@codecov-commenter
Copy link

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (5b435d9) 92.73% compared to head (354088f) 92.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #735      +/-   ##
==========================================
- Coverage   92.73%   92.60%   -0.14%     
==========================================
  Files          47       46       -1     
  Lines        3966     4002      +36     
  Branches      588      596       +8     
==========================================
+ Hits         3678     3706      +28     
- Misses        174      176       +2     
- Partials      114      120       +6     
Files Coverage Δ
wagtail_localize/modeladmin/options.py 93.93% <100.00%> (+0.60%) ⬆️
wagtail_localize/modeladmin/views.py 98.14% <100.00%> (+0.05%) ⬆️
wagtail_localize/modeladmin/helpers.py 97.43% <83.33%> (-2.57%) ⬇️
wagtail_localize/test/settings.py 97.36% <80.00%> (-2.64%) ⬇️
wagtail_localize/wagtail_hooks.py 86.33% <58.82%> (-3.53%) ⬇️
wagtail_localize/views/edit_translation.py 88.68% <73.33%> (-0.97%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zerolab zerolab merged commit 55ce6ea into main Nov 7, 2023
13 of 17 checks passed
@zerolab zerolab deleted the chore/wagtail-5.2 branch November 7, 2023 09:07
@zerolab zerolab mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wagtail_localize does not seem to work with Wagtail 5.2
2 participants